Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docusaurus displays a blank page when clicking the logo link without workaround #3299

Closed
radium-v opened this issue Jun 12, 2020 · 5 comments
Closed

Docusaurus displays a blank page when clicking the logo link without workaround #3299

radium-v opened this issue Jun 12, 2020 · 5 comments
Labels
area:site Pertains to work on the web site. bug A bug status:needs-information This issue needs more information warning:stale No recent activity within a reasonable amount of time

Comments

@radium-v
Copy link
Collaborator

Describe the bug; what happened?
Discovered in #3295 for the upcoming v2 release: clicking the documentation site's logo will display a blank page unless a workaround is in place. Currently, that workaround is in two parts:

  • For production builds: a hard-coded href is used and the link opens in the same window
  • For development builds, target: "_blank" is applied to prevent the blank page from being rendered.
@triage-new-issues triage-new-issues bot added the status:triage New Issue - needs triage label Jun 12, 2020
@EisenbergEffect EisenbergEffect added area:site Pertains to work on the web site. bug A bug status:needs-information This issue needs more information and removed status:triage New Issue - needs triage labels Jul 20, 2020
@EisenbergEffect
Copy link
Contributor

@radium-v Do we want to continue to track this or do we think our workaround is fine to stay as is? Is there anything we can really do about it?

@radium-v
Copy link
Collaborator Author

@EisenbergEffect I think the current workaround is fine (it's definitely not a major breaking bug).

@EisenbergEffect EisenbergEffect added the closed:by-design Closed by design label Jul 20, 2020
@EisenbergEffect EisenbergEffect removed the closed:by-design Closed by design label Jul 30, 2020
@scomea
Copy link
Collaborator

scomea commented Aug 13, 2020

Also, the logo on the top left corner of component explorer doesn't do anything. It should go to the Fast home page (https://explore.fast.design/)

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 25, 2020
@chrisdholt
Copy link
Member

Closing this based on the workaround being reasonable as of 2019 and no further action taken here since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:site Pertains to work on the web site. bug A bug status:needs-information This issue needs more information warning:stale No recent activity within a reasonable amount of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EisenbergEffect @radium-v @scomea @chrisdholt