Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improved border handling to components #2444

Closed
bheston opened this issue Nov 15, 2019 · 6 comments
Closed

Add improved border handling to components #2444

bheston opened this issue Nov 15, 2019 · 6 comments
Assignees
Labels
area:fast-foundation Pertains to fast-foundation docs:rfc Request for Comments (proposal)

Comments

@bheston
Copy link
Collaborator

bheston commented Nov 15, 2019

What feature are you requesting?
Currently applying borders to component elements is very manual and error prone. Here are some of the issues:

  • Placeholders for focus states
  • Different handling for filled and outlined components
  • Adjusting padding for different border thicknesses
  • Supporting thick borders, for instance, focus states that push into content
  • Using css border and box-shadow inconsistently or together

What would be the benefit of adding this feature?
Cleaning up style sheets and making applying and customizing borders easier.

What solution would be ideal for you?
Considering options to layer, contain, or decorate elements for consistent handling of fill, outline, focus, and selection states.

@bheston bheston added the improvement A non-feature-adding improvement label Nov 15, 2019
@bheston bheston self-assigned this Nov 15, 2019
@bheston bheston added discussion and removed improvement A non-feature-adding improvement labels Nov 18, 2019
@bheston
Copy link
Collaborator Author

bheston commented Dec 27, 2019

Another issue occurs on Windows where the scrollbar has buttons and a backplate. The scrollbar rectangle is drawn immediately inside the border, and above an inset box-shadow. Text inputs are currently using 1px border and 1px inset box shadow on focus, which results in:

Windows input focus border

@stale
Copy link

stale bot commented Mar 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Mar 26, 2020
@EisenbergEffect EisenbergEffect added area:fast-components area:fast-foundation Pertains to fast-foundation docs:rfc Request for Comments (proposal) and removed discussion warning:stale No recent activity within a reasonable amount of time labels Jul 17, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Dec 25, 2020
@EisenbergEffect
Copy link
Contributor

@bheston This appears to have been created prior to our web components work. Is it still relevant or can we close this?

@stale stale bot removed the warning:stale No recent activity within a reasonable amount of time label Feb 7, 2022
@bheston
Copy link
Collaborator Author

bheston commented Feb 8, 2022

@bheston This appears to have been created prior to our web components work. Is it still relevant or can we close this?

@EisenbergEffect This is actually exactly related to what came up in #5566. It relates to my current thinking around injection of styles, which is still the requirement I see for enabling a true token architecture that can be descriptively applied to any component part.

I'd like to see it stay open, and I'll try to remember it's here and link it with the work I need to take some time to write up soon.

@janechu
Copy link
Collaborator

janechu commented May 28, 2024

Removing this per #6955.

@janechu janechu closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:fast-foundation Pertains to fast-foundation docs:rfc Request for Comments (proposal)
Projects
None yet
Development

No branches or pull requests

3 participants