From fdf26fdbece15cdf007e6b1dce338560387ebbc5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Do=C4=9Fu=20Abaris?= Date: Tue, 10 Dec 2024 22:29:19 +0100 Subject: [PATCH] docs(fast-element): improve JSDoc for AttributeDefinition setValue method - Added a detailed description for the newValue parameter in the setValue method. - Ensures better clarity and documentation for the method's functionality. --- ...-fast-element-b679d332-e9c0-4e4a-984b-c06481f24caa.json | 7 +++++++ .../fast-element/src/components/attributes.ts | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 change/@microsoft-fast-element-b679d332-e9c0-4e4a-984b-c06481f24caa.json diff --git a/change/@microsoft-fast-element-b679d332-e9c0-4e4a-984b-c06481f24caa.json b/change/@microsoft-fast-element-b679d332-e9c0-4e4a-984b-c06481f24caa.json new file mode 100644 index 00000000000..6a3fb2c8173 --- /dev/null +++ b/change/@microsoft-fast-element-b679d332-e9c0-4e4a-984b-c06481f24caa.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "fast-element: Simplify conditional checks in element-controller", + "packageName": "@microsoft/fast-element", + "email": "abaris@null.net", + "dependentChangeType": "patch" +} diff --git a/packages/web-components/fast-element/src/components/attributes.ts b/packages/web-components/fast-element/src/components/attributes.ts index 3dae571d145..994ae871eaa 100644 --- a/packages/web-components/fast-element/src/components/attributes.ts +++ b/packages/web-components/fast-element/src/components/attributes.ts @@ -202,7 +202,7 @@ export class AttributeDefinition implements Accessor { /** * Sets the value of the attribute/property on the source element. * @param source - The source element to access. - * @param newValue + * @param newValue - The value to set the attribute/property to. */ public setValue(source: HTMLElement, newValue: any): void { const oldValue = source[this.fieldName];