Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetheriteProviderFactory populates ConnectionName with resolved connection string #75

Closed
ConnorMcMahon opened this issue Oct 5, 2021 · 2 comments
Closed

NetheriteProviderFactory populates ConnectionName with resolved connection string #75

ConnorMcMahon opened this issue Oct 5, 2021 · 2 comments

Comments

@ConnorMcMahon
Copy link

The ConnectionName property of DurabilityProvider is used to generate HTTP Management APIs.

By populating with the resolved connection string instead of the connection string name, we are leaking the connection string to clients when they should only need the connection string name.

Bug identified by running Activity_Gets_HttpManagementPayload with Netherite in emulator mode.
@sebastianburckhardt
Copy link
Member

Good catch. I will fix this.
I am assuming the same applies to DurableClientAttribute.ConnectionName? I will fix that also.

@sebastianburckhardt sebastianburckhardt mentioned this issue Oct 5, 2021
Merged
@sebastianburckhardt
Copy link
Member

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianburckhardt @ConnorMcMahon