Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong media type for Retrieve Instance transaction #444

Closed
hackermd opened this issue Nov 24, 2020 · 5 comments
Closed

Wrong media type for Retrieve Instance transaction #444

hackermd opened this issue Nov 24, 2020 · 5 comments
Assignees
Labels
Area-DicomRetrieve WADO-RS Bug Bug bug bug.

Comments

@hackermd
Copy link

Describe the bug
The Retrieve Instance transaction of the DICOMweb service uses the wrong media type. It should be multipart/related; type="application/dicom" instead of application/dicom. See DICOM Correction Proposal 2040 for clarification.

@StevenBorg
Copy link
Contributor

Thank you, @hackermd ! That certainly simplifies the retrieve transactions and makes all of them consistent with each other. We're looking into this now, and it certainly makes sense. Thanks! We'll keep you posted here.

@hackermd
Copy link
Author

hackermd commented Dec 9, 2020

Great! Thanks for looking into it @StevenBorg

@StevenBorg
Copy link
Contributor

@hackermd After some discussion, our take is that we should adopt the newer framework, even prior to acceptance under the standard, while still maintaining backward compatibility (in this case) for APIs which might be using the current standard. Do you see any concerns with this approach?

@hackermd
Copy link
Author

No concerns. I agree that this would be the best approach.

The "newer" framework has actually always been the standard - at least it was supposed to. The goal of Supplement 183 was to refactor the documentation of Part 18 without actually changing the behavior. Unfortunately, a few things got broken and we are currently trying to correct those. However, since Supplement 183 was officially accepted, we should probably consider application/dicom to be standard compliant or at least support it in a backwards compatible manner. We are going to do the same client-side (see ImagingDataCommons/dicomweb-client#43).

@smithago
Copy link
Contributor

smithago commented May 6, 2021

Issue is fixed. Closing

@smithago smithago closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-DicomRetrieve WADO-RS Bug Bug bug bug.
Projects
None yet
Development

No branches or pull requests

6 participants