-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for enable gui event loop when not using matplotlib #787
Conversation
@@ -61,6 +63,9 @@ def update_fom_debug_options(self, debug_options): | |||
|
|||
# Note: _max_exception_stack_frames cannot be set by debug options. | |||
|
|||
if 'ENABLE_GUI_EVENT_LOOP' in debug_options: | |||
self.enable_gui_event_loop = debug_options.get('ENABLE_GUI_EVENT_LOOP') | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit shouldn't be necessary - debugOptions
is a legacy property for boolean flags in debug config that we had before deciding to just use separate boolean properties; it is really only kept for backwards compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering what those optoins are for... Removed in f07013d
@chubei-oppen I was thinking that in the current way, to get it to work users would need to do additional work (to call something as: So, what do you think about making Does that make sense? Also, note that if that setting is not |
@fabioz Sounds good. I'll find time later for the implementaion. |
f07013d
to
c46ad22
Compare
@fabioz I force pushed the new implementation. |
Kudos, SonarCloud Quality Gate passed! |
It seems good to me, but I want to do some additional manual testing before merging (I'm finishing another issue related to gevent and as soon as I finish that I'll do the final checks/integrate this pull request, sorry for the delay here...) |
Closing in favor of #800 (which includes the changes here and has some additional fixes/tests on top of it). |
Closes #782