Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'singleThread' argument to pause requests #355

Open
HampusAdolfsson opened this issue Nov 18, 2022 · 2 comments
Open

Add 'singleThread' argument to pause requests #355

HampusAdolfsson opened this issue Nov 18, 2022 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality

Comments

@HampusAdolfsson
Copy link

Most execution requests support a 'singleThread' argument that specifices that the action should not affect threads other than the one specified by the 'threadId' argument. However, pause requests do not have this argument. Is there a reason for this?

I interpret the specification to say that pause requests should only pause one thread, but it seems equally reasonable to me that a client might want to pause all threads with a pause request.

@HampusAdolfsson
Copy link
Author

Related to #214

@int19h
Copy link

int19h commented Feb 26, 2024

Note that any debug adapter compatible with VS has to implement the "pause" request as pausing all threads, because VSDebugAdapterHost simply does not support anything else: "Visual Studio requires that all threads enter and leave break mode at the same time". But if DAP spec is to be interpreted in a sense that "pause" request should only pause a single thread, then no adapter that does it is conformant; at the minimum, it would apply to the Python debug adapter, although I suspect the actual list is longer (this is the same problem that also applied to #214). This needs to be clarified in the DAP spec; ideally, in the same way as it was done for "continue" etc for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants