Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: 'PUNCTUATION SPACE' (U+2008) #230

Closed
jeroen-mostert opened this issue Jan 13, 2020 · 2 comments · Fixed by #258
Closed

Feature Request: 'PUNCTUATION SPACE' (U+2008) #230

jeroen-mostert opened this issue Jan 13, 2020 · 2 comments · Fixed by #258

Comments

@jeroen-mostert
Copy link

Description of the new feature/enhancement (with images if possible)

My custom regional settings use U+2008 PUNCTUATION SPACE as the thousands separator in numbers. Consolas and Fira Code display this as a regular space, so Cascadia displaying a replacement character in directory listings is very visible.

If a bit of scope creep is permitted, rather than patiently gathering individual requests for all the whitespace characters, it may be worth just adding all the horizontal ones at once (mapping them to a regular space), as in "might not be correct spacing, but the best we can do in monospace, and certainly no worse than a replacement character".

@ExE-Boss
Copy link

Well U+3000 should still cover two cells, as it’s a fullwidth CJK space.

@aaronbell
Copy link
Collaborator

I'm guessing that we would end up needing to make a custom version of Cascadia to support CJK (due to full width / halfwidth support). So uni2008 would probably just be a duplicate of the normal space character in this font, at least.

Definitely worth considering adding all of the whitespace characters at once! Thanks.

@aaronbell aaronbell mentioned this issue Apr 29, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants