Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete key stops working in programmer mode if left bracket is clicked first #426

Closed
alexyorke opened this issue Apr 3, 2019 · 3 comments
Labels
duplicate Issue identified as a duplicate of another issue(s)

Comments

@alexyorke
Copy link

alexyorke commented Apr 3, 2019

The delete key (on the UI and on the keyboard) does not work after entering in a number, pressing the right bracket, then clicking delete. Even after making the brackets match, the delete button will not work (even if the input shows as (7)) until the display is cleared.

Describe the bug

Steps To Reproduce

  1. Open Calculator
  2. Open Programmer mode
  3. Select HEX mode (anything other than binary)
  4. Type the digit 7
  5. Press the right bracket )
  6. Press delete on your keyboard or in the UI. Nothing will delete.
  7. Click the left bracket (
  8. Click the right bracket ). The input will now show as (7)
  9. Click delete. Nothing will delete, even though the input is valid. Even trying to re-parenthesize the input will not fix it.
  10. Additionally, after doing something I was unable to reproduce, entering another digit was ignored until I pressed it twice.

Expected behavior

The calculator should be able to delete the digit.

Screenshots

Device and Application Information (please complete the following information):

  • OS Build: 10.0.17763.0
  • Architecture: X64
  • Application Version: 10.1902.42.0

Additional context

If I go into Scientific mode, then press the PI button, the delete key will not work.

@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@alexyorke alexyorke changed the title Delete key stops working in programmer mode if right bracket is clicked before clicking left bracket, even if brackets match Delete key stops working in programmer mode if left bracket is clicked first Apr 3, 2019
@rudyhuyn
Copy link
Contributor

rudyhuyn commented Apr 3, 2019

There are 2 issues in fact:

  • ) is considered as a "end-of-operand" even if no ( exists
  • the calculator only allows you to delete digits, not operators.

In the first case, IMO the calculator should ignore the ) and allow users to continue to edit the current operand.

In the second case, it's a little more complicated, the limitation is not only with parenthesis, but with all operators, if you type 2323 + 1 you will be allowed to only delete the 1. This is how basic (physical) calculators work, but I agree, this limitation can probably be changed.

@grochocki
Copy link
Contributor

This behavior is currently by design based on how Calculator handles input. However, I agree this is not the best experience. I believe #519 covers the "fix" for this, so closing this as a duplicate of that. If I am mistaken, and you think this might be different, we can consider reopening this.

@grochocki grochocki added the duplicate Issue identified as a duplicate of another issue(s) label Jun 13, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants