Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DialogManager refactor #6227

Closed
6 of 14 tasks
gabog opened this issue Mar 8, 2021 · 0 comments
Closed
6 of 14 tasks

DialogManager refactor #6227

gabog opened this issue Mar 8, 2021 · 0 comments
Assignees
@johnataylor
Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete

Comments

@gabog
Copy link
Contributor

gabog commented Mar 8, 2021 •
edited by stevengum
Loading

DialogManager provides almost the same functionality as ActivityHandler and could potentially be refactored to implement IBot.

As part of this issue we should look at refactoring DialogManager and reason about the impact it has on ActivityHandler and TeamsActivityHandler.

If the result is that DialogManager is a replacement for ActivityHandler we shoudl documentat that this will be the recommended way going forward and create issues in the individual repos to address this.

As part of this analysis we should also consider the impact on Docs, Samples, the Runtime and composer

Tracking Status

Dotnet SDK 5283

  • PR
  • Merged

Javascript SDK 3373

  • PR
  • Merged

Python SDK 1566

  • PR
  • Merged

Java SDK 1039

  • PR
  • Merged

Samples TODO

  • PR
  • Merged

Docs TODO

  • PR
  • Merged

Tools TODO

  • PR
  • Merged
@gabog gabog added Area: Adaptive The issue is related to Adaptive dialogs Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing labels Mar 8, 2021
This was referenced Mar 8, 2021
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnataylor johnataylor

Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) feature-request A request for new functionality or an enhancement to an existing one. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tracyboehrer @johnataylor @gabog