Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Orchestrator-BugBash] warnings when installing plugin #1054

Closed
v-kydela opened this issue Nov 10, 2020 · 3 comments
Closed

[Orchestrator-BugBash] warnings when installing plugin #1054

v-kydela opened this issue Nov 10, 2020 · 3 comments
Assignees
Labels
Area: AI-Orchestrator ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.

Comments

@v-kydela
Copy link

Versions

What CLI version are you using.
@microsoft/botframework-cli/4.11.0 win32-x64 node-v12.18.3
What Nodejs version are you using
v12.18.3
What command-line interpreters are you using
cmd
What OS are you using
Windows 8.1

Describe the bug

The following warnings are encountered when installing the Orchestrator plugin:

warning @microsoft/bf-orchestrator-cli > @microsoft/bf-orchestrator > orchestrator-core > node-gyp > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning @microsoft/bf-orchestrator-cli > @microsoft/bf-orchestrator > orchestrator-core > node-gyp > request > [email protected]: this library is no longer supported

To Reproduce

Steps to reproduce the behavior:

  1. Install the Orchestrator plugin as described here.
  2. See warnings

Expected behavior

The plugin should install without warnings

Screenshots

image

[bug]

@v-kydela v-kydela added the Orchestrator Orchestrator issues label Nov 10, 2020
@scheyal scheyal added Area: AI-Orchestrator and removed Orchestrator Orchestrator issues labels Dec 1, 2020
@daveta
Copy link
Contributor

daveta commented Jan 27, 2021

Hi @v-kydela : This warning comes from one of our dependencies. We'll update our package once the source package warning is addressed. For tracking, here's the PR from the source.

nodejs/node-gyp#2220

@tonyanziano
Copy link

Hi @daveta , was the node-gyp dependency ever bumped to get rid of this warning in bf-cli? If so, please close this issue. Thanks

@tonyanziano tonyanziano added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Jul 23, 2021
@daveta
Copy link
Contributor

daveta commented Aug 10, 2021

Yep, this was fixed - the orchestrator is now not a plugin, but in the main bf-cli package.

@daveta daveta closed this as completed Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AI-Orchestrator ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report.
Projects
None yet
Development

No branches or pull requests

4 participants