Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[botbuilder.testing] Relax dependency to allow pytest 8 #2168

Open
alexrecuenco opened this issue Sep 13, 2024 · 2 comments · May be fixed by #2189
Open

[botbuilder.testing] Relax dependency to allow pytest 8 #2168

alexrecuenco opened this issue Sep 13, 2024 · 2 comments · May be fixed by #2189
Assignees
@gandiddi

Comments

@alexrecuenco
Copy link

alexrecuenco commented Sep 13, 2024 •
edited
Loading

I see the requirements was written in #1637, a few years back

Can the pytest requirements be relaxed to allow pytest 8? Or is there anything specific that breaks with pytest 8. I was looking at the implementation of the module, and the changelog in pytest and I can't see anything that should be a big conflict

botbuilder-python/libraries/botbuilder-testing/setup.py

Line 12 in 0fba27b

"pytest~=7.3.1",

@alexrecuenco alexrecuenco changed the title Relax dependency to allow pytest 8 [botbuilder.testing] Relax dependency to allow pytest 8 Sep 13, 2024
@tracyboehrer
Copy link
Member

@alexrecuenco Well that's just it. We don't know if 8 breaks something without testing it. At the very least, restricting to major versions is more reasonable. At least for dependencies that adhere to semver. Not all do though, and any version can be breaking.

More than happy to look into this though. There is also no reason not to update older dependencies.

@alexrecuenco
Copy link
Author

Let me know if I can be of help testing anything in particular.

@gandiddi gandiddi linked a pull request Nov 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gandiddi gandiddi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bumped pytest microsoft/botbuilder-python
3 participants
@tracyboehrer @alexrecuenco @gandiddi