Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable @microsoft/api-extractor in Adaptive/Declarative packages #1965

Closed
2 of 5 tasks
stevengum opened this issue Mar 31, 2020 · 0 comments · Fixed by #2758
Closed
2 of 5 tasks

Enable @microsoft/api-extractor in Adaptive/Declarative packages #1965

stevengum opened this issue Mar 31, 2020 · 0 comments · Fixed by #2758
Assignees
@chon219
Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Milestone
R11

Comments

@stevengum
Copy link
Member

stevengum commented Mar 31, 2020 •
edited
Loading

Describe the bug

Enable @microsoft/api-extractor for the following libraries:

  • adaptive-expressions
  • botbuilder-lg
  • botbuilder-dialogs-adaptive-tests (in 4.future)
  • botbuilder-dialogs-adaptive (in 4.future)
  • botbuilder-dialogs-declarative (in 4.future)

Expected behavior

Adaptive/LG/Declarative libraries undergo same checks for breaking changes.

Additional context

Original @microsoft/api-extractor issue: #1903

[bug]
@stevengum stevengum added the R11 label Jun 4, 2020
@stevengum stevengum changed the title Enable @microsoft/api-extractor in Adaptive/LG/Declarative packages Enable @microsoft/api-extractor in Adaptive/Declarative packages Jun 4, 2020
@munozemilio munozemilio added this to the R11 milestone Jul 1, 2020
@chon219 chon219 mentioned this issue Sep 2, 2020
Merged
@chon219 chon219 self-assigned this Sep 2, 2020
@gabog gabog added Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Area: Adaptive The issue is related to Adaptive dialogs and removed Engineering labels Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chon219 chon219

Labels
Area: Adaptive The issue is related to Adaptive dialogs Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Projects
None yet
Milestone
R11
Development

Successfully merging a pull request may close this issue.

Enabled api-extractor in adaptive/declarative/adaptive-testing packages microsoft/botbuilder-js
4 participants
@chon219 @gabog @stevengum @munozemilio