Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Throw on decode certificate errors #899

Closed
tracyboehrer opened this issue Jan 11, 2021 · 0 comments · Fixed by #904
Closed

Throw on decode certificate errors #899

tracyboehrer opened this issue Jan 11, 2021 · 0 comments · Fixed by #904
Assignees
Labels
Area: Authentication The issue is related to authenticating users (SSO, OAuth, etc.) P0 Must Fix. Release-blocker
Milestone

Comments

@tracyboehrer
Copy link
Member

JwtTokenExtractor.validateToken

                    // Note that decodeCertificate will return null if the cert could not
                    // be decoded.  This would likely be the case if it were in an unexpected
                    // encoding.  Going to err on the side of ignoring this check.
                    // May want to reconsider this and throw on null cert.
                    X509Certificate cert = decodeCertificate(key.certificateChain.get(0));
                    if (cert != null && !isCertValid(cert)) {
                        throw new JWTVerificationException("Signing certificate is not valid");
                    }
@tracyboehrer tracyboehrer added P0 Must Fix. Release-blocker discussion Want to talk about this issue in order to reach a decision Area: Authentication The issue is related to authenticating users (SSO, OAuth, etc.) labels Jan 11, 2021
@tracyboehrer tracyboehrer added this to the R12 milestone Jan 11, 2021
@tracyboehrer tracyboehrer self-assigned this Jan 11, 2021
@tracyboehrer tracyboehrer removed the discussion Want to talk about this issue in order to reach a decision label Jan 13, 2021
@tracyboehrer tracyboehrer changed the title Research null cert handling Throw on null certificate Jan 13, 2021
@tracyboehrer tracyboehrer changed the title Throw on null certificate Throw on decode certificate errors Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Authentication The issue is related to authenticating users (SSO, OAuth, etc.) P0 Must Fix. Release-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant