This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
BotDependencyConfiguration defines ExecutorService bean but its not in use #1339
Labels
Bot Services
Required for internal Azure reporting. Do not delete. Do not change color.
customer-reported
Issue is created by anyone that is not a collaborator in the repository.
feature-request
A request for new functionality or an enhancement to an existing one.
needs-triage
The issue has just been created and it has not been reviewed by the team.
Comments
przem
added
feature-request
przem
changed the title
dmvtech
added
Bot Services
|
@przem Hi, may I ask how you swapped out the ExecutorFactory#factory. In my case, I could not load classpath resources from within the SpringBoot jar, because of the wrong class loader ExecutorFactory#factory uses. Love to find out the fix. Appreciate it! btw, if JDK 1.8 is used, do you still have the same issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is your feature request related to a problem? Please describe.
The problem i've stumbled upon is that i was getting
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type `java.time.OffsetDateTime` not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through reference chain: com.microsoft.bot.schema.Activity["timestamp"])error for missing module that was already in the deps. The cause was thatExecutorFactory#factorywas using wrong classloader and module was not there. Had to do nasty reflection tricks to exchange the factory.Describe the solution you'd like
I'd like that
BotFrameworkAdapterutilize theExecutorServicespring bean. This could be done by expanding constructor ofBotFrameworkAdapterto acceptExecutorService, and also other classes like BotFrameworkHttpAdapter AdapterWithErrorHandlerThe text was updated successfully, but these errors were encountered: