Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

port: SetSpeakMiddleware - remove lang argument (#5404) #1122

Closed
github-actions bot opened this issue Apr 1, 2021 · 0 comments · Fixed by #1123
Closed

port: SetSpeakMiddleware - remove lang argument (#5404) #1122

github-actions bot opened this issue Apr 1, 2021 · 0 comments · Fixed by #1123
Assignees
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. parity The issue describes a gap in parity between two or more platforms.
Milestone

Comments

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

The changes in SetSpeakMiddleware - remove lang argument (#5404) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5403

Description

Once this is merged the adaptive runtime implementation will need to be updated to remove the argument when adding the middleware.

Please review and, if necessary, port the changes.

@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Apr 1, 2021
@tracyboehrer tracyboehrer added this to the R13 milestone Apr 1, 2021
@tracyboehrer tracyboehrer added Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants