Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adaptive] Adaptive dialogs + LG debuggability #2385

Closed
vishwacsena opened this issue Aug 8, 2019 · 11 comments · Fixed by #3791
Closed

[Adaptive] Adaptive dialogs + LG debuggability #2385

vishwacsena opened this issue Aug 8, 2019 · 11 comments · Fixed by #3791
Assignees
Labels
Area: LG Language generation issues P1 Painful if we don't fix, won't block releasing triaged Reviewed by the Triage Team
Milestone

Comments

@vishwacsena
Copy link
Contributor

Work here builds on top of the inspection middleware to enable improved debugging experience with adaptive dialogs.

  1. Add support for ability in the runtime to break at a specific step in an adaptive dialog
  2. Add ability to continue to next step and break once a break step has been encountered.
  3. Add ability to continue till next break point (if any) once a break step has been encountered.
  4. Add debug break property for all steps and events.
@vishwacsena vishwacsena added the R7 Release 7 - December 10th, 2019 label Oct 20, 2019
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Nov 20, 2019
@vishwacsena vishwacsena removed R7 Release 7 - December 10th, 2019 stale The issue hasn't been updated in a long time and will be automatically closed. labels Dec 11, 2019
@vishwacsena vishwacsena reopened this Dec 11, 2019
@vishwacsena
Copy link
Contributor Author

Decision for R8

  • Property (emitTrace with expression as value) for all actions that emit a trace when the action is executed

Emulator [?]:

  • DialogState inspector
    • Trace output was a bit more structured and promote dialogState up if available in a trace
    • Add ability to eval expressions against dialog state

@vishwacsena vishwacsena assigned vishwacsena and unassigned Stevenic Dec 19, 2019
@vishwacsena vishwacsena added the R9 Release 9 - May 15th, 2020 label Jan 16, 2020
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The issue hasn't been updated in a long time and will be automatically closed. label Feb 16, 2020
@vishwacsena vishwacsena removed the stale The issue hasn't been updated in a long time and will be automatically closed. label Feb 16, 2020
@vishwacsena
Copy link
Contributor Author

vishwacsena commented Mar 10, 2020

Decision R9
- vs code, vs extension ships
- lg hook up for debug protocol
- [Will] debug protocol for composer

@vishwacsena vishwacsena added the LG label Mar 10, 2020
@vishwacsena vishwacsena changed the title [Adaptive] Expand debuggability with a debug break property on all events and actions [Adaptive] Adaptive dialogs + LG debuggability Mar 10, 2020
@vishwacsena vishwacsena added the triaged Reviewed by the Triage Team label Mar 15, 2020
@vishwacsena vishwacsena assigned boydc2014 and unassigned vishwacsena Mar 15, 2020
@vishwacsena vishwacsena added P0 Must Fix. Release-blocker and removed adaptive labels Apr 8, 2020
@cleemullins
Copy link
Contributor

@vishwacsena, this is a P0 bug from Aug 7, making it 9 months old. If we push to R10, we can celebrate it's 1-year birthday.

@boydc2014
Copy link
Contributor

boydc2014 commented Apr 9, 2020

@cleemullins

The issue is old because that, this issue is initially created for tracking debugability for Adaptive, which is supported in R8 already, then in the end of R8 and starting of R9, we start talking about we should include LG debug ability as well. Then it just become P0 in R9.

@vishwacsena vishwacsena added P1 Painful if we don't fix, won't block releasing and removed P0 Must Fix. Release-blocker labels Apr 13, 2020
@vishwacsena
Copy link
Contributor Author

@boydc2014 chatted with Scott this morning. Tagging as P1.

@cleemullins
Copy link
Contributor

@vishwacasena, @boydc2014 Updates?

@boydc2014
Copy link
Contributor

boydc2014 commented Apr 30, 2020

@vishwacasena, @boydc2014 Updates?

The PR is referenced as above, going through a couple rounds review already, issues on my side are clear, Tom is reviewing now, i see a few nits, expected to be closed soon.

@sgellock sgellock added R10 Release 10 - August 17th, 2020 and removed R9 Release 9 - May 15th, 2020 labels Apr 30, 2020
@sgellock
Copy link
Member

given the national holiday and the fact that we're cutting RC builds, I'm moving this out of the R9 milestone and into R10.

@munozemilio munozemilio added this to the R10 milestone Jul 1, 2020
@mrivera-ms mrivera-ms added blocked Current progress is blocked on something else. and removed R10 Release 10 - August 17th, 2020 labels Aug 6, 2020
@mrivera-ms
Copy link
Contributor

Discussed with @boydc2014 , this is blocked and being removed from R10 and pushed to R11.

@mrivera-ms mrivera-ms modified the milestones: R10, R11 Aug 6, 2020
@vishwacsena vishwacsena added Area: LG Language generation issues and removed LG labels Aug 16, 2020
@boydc2014 boydc2014 removed the blocked Current progress is blocked on something else. label Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LG Language generation issues P1 Painful if we don't fix, won't block releasing triaged Reviewed by the Triage Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants