Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target netstandard2.0 for c# #1190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Target netstandard2.0 for c# #1190

wants to merge 1 commit into from

Conversation

ShortDevelopment
Copy link

@ShortDevelopment ShortDevelopment commented May 11, 2023 •
edited
Loading

Changes

  • Update net45 to net462 (examples and tests)
  • Target netstandard2.0 in libs
  • Remove conditional compilation
  • Fix nuget files

Fixes #1189

@ShortDevelopment
Copy link
Author

@microsoft-github-policy-service agree

@ShortDevelopment ShortDevelopment force-pushed the csharp-netstandard20 branch 2 times, most recently from e128f0f to 0140c67 Compare May 12, 2023 09:26
@ShortDevelopment ShortDevelopment marked this pull request as ready for review May 12, 2023 09:27
@chwarr
Copy link
Member

chwarr commented May 17, 2023

Thanks for the PR! Things are quite busy here, as we have Microsoft Build in a few week. This change will need some extra validation, and I won't have time for that until later in the month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Target netstandard2.0 for c#
2 participants
@ShortDevelopment @chwarr