This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Added Dockerfile with Bedrock prerequisites #1407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@andrebriggs - there was a plan to follow up on this? |
|
Hi @carlessanagustin thanks for the PR! Typically when making a PR for something more substantial we ask folks follow this guidance. I've added some feedback to the PR |
andrebriggs
suggested changes
Jun 1, 2020
| @@ -1,3 +1,6 @@ | |||
| from: https://youtu.be/H5uq60pb2Hs | |||
| @@ -0,0 +1,20 @@ | |||
| FROM debian:stretch | |||
| LABEL createdBy="https://twitter.com/carlesanagustin" | |||
| then | ||
| exit 1 | ||
| fi | ||
| # next 6 lines commented due to automation |
There was a problem hiding this comment.
All these changes to the shell scripts make it difficult to re-use as they previously were. I suggest adding an override instead of commenting out these blocks.
There was a problem hiding this comment.
Setting an environment variable in the Dockerfile like ASSUME_YES or NO_INPUT, maybe prefixed with BEDROCK_ could work?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dockerfile with Bedrock prerequisites installed in Debian based image ready to use. Instructions and usage come in Makefile. Documentation is updated in 2x README.md files.