Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

spk reconcile should use fab add --type helm #916

Closed
evanlouie opened this issue Jan 28, 2020 · 0 comments · Fixed by CatalystCode/spk#223
Closed

spk reconcile should use fab add --type helm #916

evanlouie opened this issue Jan 28, 2020 · 0 comments · Fixed by CatalystCode/spk#223
Assignees
Labels
bug Something isn't working

Comments

@evanlouie
Copy link
Contributor

evanlouie commented Jan 28, 2020

Describe the bug: spk reconcile should specify --type helm when doing
fab add when adding the helm chart component to a ring.

See:

To Reproduce: run spk reconcile on a bedrock project with at least one
service with a valid IHelmConfig. Note the created component for the helm chart
is of type component. Causing fab install to fail.

  • mkdir app hld
  • cd app
  • spk project init
  • spk service create my-service -n traefik -b master -p traefik -g https://github.com/containous/traefik-helm-chart.git
  • cd ..
  • cd hld
  • spk hld init
  • cd ..
  • spk hld reconcile my-app-component hld app
  • cat hld/my-app-component/my-service/master
    • will yield:
      name: master
      type: component
      subcomponents:
      - name: chart
        type: component # should be of 'helm' instead of 'component'
        source: https://github.com/containous/traefik-helm-chart.git
        method: git
        path: traefik
        branch: master
      - name: static
        type: static
        method: local
        path: ./static
      
  • subcomponent chart should be of type: helm not type: component

Expected behavior: spk reconcile works properly and the underlying
fab install calls install the components correctly.

Screenshots:

Additional context:

Does this require updates to documentation?:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants