add variable format warning

microsoft · Apr 15, 2020 · 4194aaf · 4194aaf
1 parent a94319e
commit 4194aaf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/commands/service/create.ts b/src/commands/service/create.ts
@@ -56,6 +56,10 @@ export interface CommandValues extends CommandOptions {
   serviceVariablesArray: string[];
 }
 
+export const validUpperUnderscoreCase = (segment: string): boolean => {
+  return !!segment.match(/^[A-Z0-9_]+$/);
+};
+
 export const fetchValues = (opts: CommandOptions): CommandValues => {
   if (!isPortNumberString(opts.k8sBackendPort)) {
     throw Error("value for --k8s-service-port is not a valid port number");
@@ -82,6 +86,12 @@ export const fetchValues = (opts: CommandOptions): CommandValues => {
       .map((str) => str.trim());
   }
 
+  serviceVariablesArray.forEach(function (r) {
+    if (!validUpperUnderscoreCase(r)) {
+      logger.warn(`${r} is not in a valid format. Valid strings include only uppercases, numbers, and underscores.`);
+    }
+  });
+
   const values: CommandValues = {
     gitPush: opts.gitPush,
     helmChartChart: opts.helmChartChart,

diff --git a/src/lib/fileutils.ts b/src/lib/fileutils.ts
@@ -146,8 +146,6 @@ export const serviceBuildAndUpdatePipeline = (
   const relativeServiceForDockerfile = relServicePath.startsWith("./")
     ? relServicePath
     : "./" + relServicePath;
-  // const test = (serviceBuildVariables ?? []).map((group) => ({ group }));
-  // logger.info(`${test}`);
 
   const pipelineYaml: AzurePipelinesYaml = {
     trigger: {