Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission management #6

Open
dnws opened this issue Nov 27, 2019 · 1 comment
Open

Permission management #6

dnws opened this issue Nov 27, 2019 · 1 comment

Comments

@dnws
Copy link

dnws commented Nov 27, 2019

Hello!

The extensions does exactly what it states, thanks for sharing it! However, I have a question about permissions.
In code I see no explicit permission validation, if user actually being a member of Project Collection Administrators (PCA) group or not, but verified it is working, as expected, only for PCAs. Do i get it right that code just relies on fact that API call will be failing if personal token gets rejected by some ADO internal permission policies? Or am I missing something?

Thanks

@j-windsor
Copy link
Contributor

That is correct. As of now, the permission model relies on a failing request. Good suggestion! We can eventually get around to this, but I encourage you to implement if you have a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants