Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Adding Mariner's GPG keys to RPM's database in the worker chroot. #2640

Merged
merged 5 commits into from
Mar 31, 2022

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Mar 31, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Recent update of TDNF made it display a few more yes/no questions, which caused failures for derivative builds reaching out to the PMC repository (no issues in core builds, since they relied on local packages). We're now making sure that RPM has imported Mariner's GPG keys before running any TDNF commands in the chroot.

Change Log
  • Importing Mariner's GPG keys during chroot's creation.
  • Making TNDF install Mariner's GPG keys automatically, if mariner-repos-shared is present.
Does this affect the toolchain?

Yes.

Test Methodology
  • Local demo package and VHD build.

@PawelWMS PawelWMS requested a review from a team as a code owner March 31, 2022 22:28
@ghost ghost added the main PR Destined for main label Mar 31, 2022
@PawelWMS PawelWMS merged commit 1c234d6 into microsoft:main Mar 31, 2022
@PawelWMS PawelWMS deleted the pawelwi/fixing_tdnf_calls branch March 31, 2022 23:22
@PawelWMS PawelWMS mentioned this pull request May 3, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants