Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Updating nodejs to 14.18.3 to fix CVE-2021-44531. #2463

Closed
wants to merge 2 commits into from

Conversation

PawelWMS
Copy link
Contributor

@PawelWMS PawelWMS commented Mar 10, 2022

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Fixing CVE-2021-44531 in nodejs.

Change Log
  • Updated nodejs to 14.18.3.
Does this affect the toolchain?

No.

Associated issues
Links to CVEs
Test Methodology
  • Pipeline build id: 174254.

@PawelWMS PawelWMS requested a review from a team as a code owner March 10, 2022 22:15
@PawelWMS
Copy link
Contributor Author

Looks like we're upgrading to an even newer version in main: #2485. I'll close this PR, if the other one gets merged.

@PawelWMS PawelWMS mentioned this pull request Mar 14, 2022
11 tasks
@anphel31 anphel31 added the main PR Destined for main label Mar 18, 2022
@nicogbg
Copy link
Contributor

nicogbg commented Mar 18, 2022

Do not merge that PR because another PR will upgrade Nodejs to 16.14.0 and both PR will conflict !!!

@nicogbg nicogbg closed this Mar 18, 2022
@PawelWMS PawelWMS deleted the pawelwi/fixing_nodejs_CVE_main branch March 18, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants