Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sql Authentication Provider breaks login #23210

Closed
scottrudy opened this issue May 25, 2023 · 6 comments · Fixed by #23263 or microsoft/vscode-mssql#17710
Closed

Sql Authentication Provider breaks login #23210

scottrudy opened this issue May 25, 2023 · 6 comments · Fixed by #23263 or microsoft/vscode-mssql#17710
Labels
Approved Area - Connection Bug Size: S For a small complexity issue - only when fixed with a PR Triage: Done

Comments

@scottrudy
Copy link

scottrudy commented May 25, 2023

  • Azure Data Studio Version: 1.44.0
  • OS Version: Version 22H2 (OS Build 19045.2965)

Steps to Reproduce:

  1. Upgrade from version 1.43.0 to 1.44.0
  2. Try to login to a database using "Azure Active Directory - Universal with MFA support"
  3. Get message, Invalid email address format for user: [Department)] received for Azure Active Directory authentication.
    • Important: the display name of the user is in the format "LastName, FirstName :(Role - Department)"
    • The email address is in the format [email protected] and the UPN is in the format [email protected]

Does this issue occur when all extensions are disabled?: Yes

I'm guessing this has to do with the display name having a dash. I imagine Studio is trying to get the UPN for login by looking for the first "-" and it should be looking for the last instance of the "-" in that string. Note that disabling SQL Authentication Provider allows for a workaround.

1-Azure Accounts.log

@github-actions
Copy link

We need more info to debug your Azure Active Directory issue. If you could attach your logs to the issue (ensure no private data is in them), it would help us fix the issue much faster.

  • In the settings menu, find the setting titled Azure: Logging Level and select the Verbose option
  • Run the process that produces your error
  • Open command palette (Click View -> Command Palette)
  • Run the command: Developer: Open Logs Folder
  • Follow this path to find the Azure Accounts log file: [default log folder]/exthost1/output_logging_[earliest timestamp]/#-Azure Acounts.log
  • Please attach the Azure-Accounts.log file to the issue.

@cheenamalhotra
Copy link
Member

cheenamalhotra commented May 25, 2023

I believe this is a special scenario and can be fixed by ensuring we capture the last index of ' - '. Thanks for letting us know!

You may continue to use workaround in the meantime.

@scottrudy
Copy link
Author

scottrudy commented May 25, 2023

I did the steps for logging anyway, but even after encountering the error the Azure Accounts.log file is empty.

@cheenamalhotra
Copy link
Member

You may need to reload Azure Data Studio to allow setting to take effect.

@darknoon29
Copy link

darknoon29 commented May 29, 2023

Same issue on my side with an email account using the following format: [email protected]

@jk-at-kf
Copy link

I'm getting that as well format is: [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Area - Connection Bug Size: S For a small complexity issue - only when fixed with a PR Triage: Done
Projects
None yet
6 participants