Separate Java-related code from guidance library #7888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelldi
force-pushed
the
split-azure-intellij-plugin-guidance-library-2
branch
from
5778c0b
to
6d09994
Compare
|
I fixed the merge conflicts |
|
Hello @Flanker32! I apologize for pinging you, but could you please take a look. I'm afraid of new merge conflicts. |
|
@rafaelldi Thanks a lot for the efforts and sorry for the late response, the PR looks fine to me~ |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Hello! I created an
azure-intellij-plugin-guidance-javalibrary and moved all the java-specific code from theazure-intellij-plugin-guidancebase library there. This will allow us to use this library (and theazure-intellij-plugin-appservicelibrary) for other languages.Does this close any currently open issues?
No
Any relevant logs, screenshots, error output, etc.?
None
Any other comments?
…
Has this been tested?