From 83aa3e5e6847e11be62410573ee1b2da1de6a6ba Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 12:54:03 +0100 Subject: [PATCH 01/11] Fail AppCenterDistributeV1 task --- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- Tasks/AppCenterDistributeV1/appcenterdistribute.ts | 6 ++++++ Tasks/AppCenterDistributeV1/task.json | 5 +++-- Tasks/AppCenterDistributeV1/task.loc.json | 5 +++-- _generated/AppCenterDistributeV1.versionmap.txt | 4 ++-- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- .../AppCenterDistributeV1_Node20/appcenterdistribute.ts | 6 ++++++ _generated/AppCenterDistributeV1_Node20/task.json | 9 +++++---- _generated/AppCenterDistributeV1_Node20/task.loc.json | 9 +++++---- 9 files changed, 34 insertions(+), 16 deletions(-) diff --git a/Tasks/AppCenterDistributeV1/Strings/resources.resjson/en-US/resources.resjson b/Tasks/AppCenterDistributeV1/Strings/resources.resjson/en-US/resources.resjson index b06ecc2d0491..c946550ca471 100644 --- a/Tasks/AppCenterDistributeV1/Strings/resources.resjson/en-US/resources.resjson +++ b/Tasks/AppCenterDistributeV1/Strings/resources.resjson/en-US/resources.resjson @@ -38,5 +38,6 @@ "loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.", "loc.messages.FoundMultipleFiles": "Found multiple files matching %s.", "loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.", - "loc.messages.FailedToFindFile": "Failed to find %s at %s." + "loc.messages.FailedToFindFile": "Failed to find %s at %s.", + "loc.messages.DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." } \ No newline at end of file diff --git a/Tasks/AppCenterDistributeV1/appcenterdistribute.ts b/Tasks/AppCenterDistributeV1/appcenterdistribute.ts index d587a73552f2..460843ee5e03 100644 --- a/Tasks/AppCenterDistributeV1/appcenterdistribute.ts +++ b/Tasks/AppCenterDistributeV1/appcenterdistribute.ts @@ -445,6 +445,12 @@ async function run() { try { tl.setResourcePath(path.join(__dirname, 'task.json')); + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } + // Get build inputs let apiEndpointData = getEndpointDetails('serverEndpoint'); let apiToken: string = apiEndpointData.authToken; diff --git a/Tasks/AppCenterDistributeV1/task.json b/Tasks/AppCenterDistributeV1/task.json index 61d771498883..07c616c22f0a 100644 --- a/Tasks/AppCenterDistributeV1/task.json +++ b/Tasks/AppCenterDistributeV1/task.json @@ -17,7 +17,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Fix bug where feature branches were being truncated.", @@ -201,6 +201,7 @@ "CannotFindAnyFile": "Cannot find any file based on %s.", "FoundMultipleFiles": "Found multiple files matching %s.", "FailedToCreateFile": "Failed to create %s with error: %s.", - "FailedToFindFile": "Failed to find %s at %s." + "FailedToFindFile": "Failed to find %s at %s.", + "DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." } } \ No newline at end of file diff --git a/Tasks/AppCenterDistributeV1/task.loc.json b/Tasks/AppCenterDistributeV1/task.loc.json index 28213344c602..8925f9f41e61 100644 --- a/Tasks/AppCenterDistributeV1/task.loc.json +++ b/Tasks/AppCenterDistributeV1/task.loc.json @@ -17,7 +17,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", @@ -201,6 +201,7 @@ "CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile", "FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles", "FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile", - "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile" + "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV1.versionmap.txt b/_generated/AppCenterDistributeV1.versionmap.txt index 03c75e2e696e..3e5f935ff138 100644 --- a/_generated/AppCenterDistributeV1.versionmap.txt +++ b/_generated/AppCenterDistributeV1.versionmap.txt @@ -1,2 +1,2 @@ -Default|1.234.0 -Node20_229_7|1.234.1 +Default|1.234.2 +Node20_229_7|1.234.3 diff --git a/_generated/AppCenterDistributeV1_Node20/Strings/resources.resjson/en-US/resources.resjson b/_generated/AppCenterDistributeV1_Node20/Strings/resources.resjson/en-US/resources.resjson index b06ecc2d0491..c946550ca471 100644 --- a/_generated/AppCenterDistributeV1_Node20/Strings/resources.resjson/en-US/resources.resjson +++ b/_generated/AppCenterDistributeV1_Node20/Strings/resources.resjson/en-US/resources.resjson @@ -38,5 +38,6 @@ "loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.", "loc.messages.FoundMultipleFiles": "Found multiple files matching %s.", "loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.", - "loc.messages.FailedToFindFile": "Failed to find %s at %s." + "loc.messages.FailedToFindFile": "Failed to find %s at %s.", + "loc.messages.DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts b/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts index d587a73552f2..460843ee5e03 100644 --- a/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts +++ b/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts @@ -445,6 +445,12 @@ async function run() { try { tl.setResourcePath(path.join(__dirname, 'task.json')); + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } + // Get build inputs let apiEndpointData = getEndpointDetails('serverEndpoint'); let apiToken: string = apiEndpointData.authToken; diff --git a/_generated/AppCenterDistributeV1_Node20/task.json b/_generated/AppCenterDistributeV1_Node20/task.json index 1bb5e4e33174..c9c106ff9891 100644 --- a/_generated/AppCenterDistributeV1_Node20/task.json +++ b/_generated/AppCenterDistributeV1_Node20/task.json @@ -17,7 +17,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Fix bug where feature branches were being truncated.", @@ -205,10 +205,11 @@ "CannotFindAnyFile": "Cannot find any file based on %s.", "FoundMultipleFiles": "Found multiple files matching %s.", "FailedToCreateFile": "Failed to create %s with error: %s.", - "FailedToFindFile": "Failed to find %s at %s." + "FailedToFindFile": "Failed to find %s at %s.", + "DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20_229_7": "1.234.1" + "Default": "1.234.2", + "Node20_229_7": "1.234.3" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV1_Node20/task.loc.json b/_generated/AppCenterDistributeV1_Node20/task.loc.json index 94a9a1315fb0..acb5d47ff1c2 100644 --- a/_generated/AppCenterDistributeV1_Node20/task.loc.json +++ b/_generated/AppCenterDistributeV1_Node20/task.loc.json @@ -17,7 +17,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", @@ -205,10 +205,11 @@ "CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile", "FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles", "FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile", - "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile" + "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20_229_7": "1.234.1" + "Default": "1.234.2", + "Node20_229_7": "1.234.3" } } \ No newline at end of file From e316d3b795200cf3d045fd3884d0a9ef11d84291 Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 12:54:53 +0100 Subject: [PATCH 02/11] Fix fail location --- Tasks/AppCenterDistributeV1/appcenterdistribute.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Tasks/AppCenterDistributeV1/appcenterdistribute.ts b/Tasks/AppCenterDistributeV1/appcenterdistribute.ts index 460843ee5e03..6742d8e9a352 100644 --- a/Tasks/AppCenterDistributeV1/appcenterdistribute.ts +++ b/Tasks/AppCenterDistributeV1/appcenterdistribute.ts @@ -445,12 +445,6 @@ async function run() { try { tl.setResourcePath(path.join(__dirname, 'task.json')); - let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); - - if (shouldFail != null && shouldFail.toLowerCase() === 'true') { - throw new Error(tl.loc("DeprecatedTask")); - } - // Get build inputs let apiEndpointData = getEndpointDetails('serverEndpoint'); let apiToken: string = apiEndpointData.authToken; @@ -564,6 +558,12 @@ async function run() { await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent); } + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } + tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded")); } catch (err) { tl.setResult(tl.TaskResult.Failed, `${err}`); From 0ef8857b3e1566ca8fdf3b69d52086df3224b1fa Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 13:02:30 +0100 Subject: [PATCH 03/11] Fail AppCenterDistributeV2 task --- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- Tasks/AppCenterDistributeV2/appcenterdistribute.ts | 6 ++++++ Tasks/AppCenterDistributeV2/task.json | 5 +++-- Tasks/AppCenterDistributeV2/task.loc.json | 5 +++-- _generated/AppCenterDistributeV2.versionmap.txt | 4 ++-- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- .../AppCenterDistributeV2_Node20/appcenterdistribute.ts | 6 ++++++ _generated/AppCenterDistributeV2_Node20/task.json | 9 +++++---- _generated/AppCenterDistributeV2_Node20/task.loc.json | 9 +++++---- 9 files changed, 34 insertions(+), 16 deletions(-) diff --git a/Tasks/AppCenterDistributeV2/Strings/resources.resjson/en-US/resources.resjson b/Tasks/AppCenterDistributeV2/Strings/resources.resjson/en-US/resources.resjson index 9c3ec1f83437..0d154f652428 100644 --- a/Tasks/AppCenterDistributeV2/Strings/resources.resjson/en-US/resources.resjson +++ b/Tasks/AppCenterDistributeV2/Strings/resources.resjson/en-US/resources.resjson @@ -39,5 +39,6 @@ "loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.", "loc.messages.FoundMultipleFiles": "Found multiple files matching %s.", "loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.", - "loc.messages.FailedToFindFile": "Failed to find %s at %s." + "loc.messages.FailedToFindFile": "Failed to find %s at %s.", + "loc.messages.DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." } \ No newline at end of file diff --git a/Tasks/AppCenterDistributeV2/appcenterdistribute.ts b/Tasks/AppCenterDistributeV2/appcenterdistribute.ts index 66415fd7328d..1857f439e3df 100644 --- a/Tasks/AppCenterDistributeV2/appcenterdistribute.ts +++ b/Tasks/AppCenterDistributeV2/appcenterdistribute.ts @@ -547,6 +547,12 @@ async function run() { await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent); } + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } + tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded")); } catch (err) { tl.setResult(tl.TaskResult.Failed, `${err}`); diff --git a/Tasks/AppCenterDistributeV2/task.json b/Tasks/AppCenterDistributeV2/task.json index 7ac99376ee57..78011f5248ab 100644 --- a/Tasks/AppCenterDistributeV2/task.json +++ b/Tasks/AppCenterDistributeV2/task.json @@ -17,7 +17,7 @@ "version": { "Major": 2, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Added support for multiple destinations.", @@ -203,6 +203,7 @@ "CannotFindAnyFile": "Cannot find any file based on %s.", "FoundMultipleFiles": "Found multiple files matching %s.", "FailedToCreateFile": "Failed to create %s with error: %s.", - "FailedToFindFile": "Failed to find %s at %s." + "FailedToFindFile": "Failed to find %s at %s.", + "DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." } } diff --git a/Tasks/AppCenterDistributeV2/task.loc.json b/Tasks/AppCenterDistributeV2/task.loc.json index fb0fbc936cd6..cef72c8e15eb 100644 --- a/Tasks/AppCenterDistributeV2/task.loc.json +++ b/Tasks/AppCenterDistributeV2/task.loc.json @@ -17,7 +17,7 @@ "version": { "Major": 2, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", @@ -203,6 +203,7 @@ "CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile", "FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles", "FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile", - "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile" + "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV2.versionmap.txt b/_generated/AppCenterDistributeV2.versionmap.txt index cdfd3eac38e5..70efee6e7aad 100644 --- a/_generated/AppCenterDistributeV2.versionmap.txt +++ b/_generated/AppCenterDistributeV2.versionmap.txt @@ -1,2 +1,2 @@ -Default|2.234.0 -Node20_229_7|2.234.1 +Default|2.234.2 +Node20_229_7|2.234.3 diff --git a/_generated/AppCenterDistributeV2_Node20/Strings/resources.resjson/en-US/resources.resjson b/_generated/AppCenterDistributeV2_Node20/Strings/resources.resjson/en-US/resources.resjson index 9c3ec1f83437..0d154f652428 100644 --- a/_generated/AppCenterDistributeV2_Node20/Strings/resources.resjson/en-US/resources.resjson +++ b/_generated/AppCenterDistributeV2_Node20/Strings/resources.resjson/en-US/resources.resjson @@ -39,5 +39,6 @@ "loc.messages.CannotFindAnyFile": "Cannot find any file based on %s.", "loc.messages.FoundMultipleFiles": "Found multiple files matching %s.", "loc.messages.FailedToCreateFile": "Failed to create %s with error: %s.", - "loc.messages.FailedToFindFile": "Failed to find %s at %s." + "loc.messages.FailedToFindFile": "Failed to find %s at %s.", + "loc.messages.DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV2_Node20/appcenterdistribute.ts b/_generated/AppCenterDistributeV2_Node20/appcenterdistribute.ts index 66415fd7328d..1857f439e3df 100644 --- a/_generated/AppCenterDistributeV2_Node20/appcenterdistribute.ts +++ b/_generated/AppCenterDistributeV2_Node20/appcenterdistribute.ts @@ -547,6 +547,12 @@ async function run() { await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent); } + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } + tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded")); } catch (err) { tl.setResult(tl.TaskResult.Failed, `${err}`); diff --git a/_generated/AppCenterDistributeV2_Node20/task.json b/_generated/AppCenterDistributeV2_Node20/task.json index 3d07a8f0e5c5..f3a11d8546e4 100644 --- a/_generated/AppCenterDistributeV2_Node20/task.json +++ b/_generated/AppCenterDistributeV2_Node20/task.json @@ -17,7 +17,7 @@ "version": { "Major": 2, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Added support for multiple destinations.", @@ -207,10 +207,11 @@ "CannotFindAnyFile": "Cannot find any file based on %s.", "FoundMultipleFiles": "Found multiple files matching %s.", "FailedToCreateFile": "Failed to create %s with error: %s.", - "FailedToFindFile": "Failed to find %s at %s." + "FailedToFindFile": "Failed to find %s at %s.", + "DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." }, "_buildConfigMapping": { - "Default": "2.234.0", - "Node20_229_7": "2.234.1" + "Default": "2.234.2", + "Node20_229_7": "2.234.3" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV2_Node20/task.loc.json b/_generated/AppCenterDistributeV2_Node20/task.loc.json index d4f8bfdfdfcc..a3ced2653a9a 100644 --- a/_generated/AppCenterDistributeV2_Node20/task.loc.json +++ b/_generated/AppCenterDistributeV2_Node20/task.loc.json @@ -17,7 +17,7 @@ "version": { "Major": 2, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", @@ -207,10 +207,11 @@ "CannotFindAnyFile": "ms-resource:loc.messages.CannotFindAnyFile", "FoundMultipleFiles": "ms-resource:loc.messages.FoundMultipleFiles", "FailedToCreateFile": "ms-resource:loc.messages.FailedToCreateFile", - "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile" + "FailedToFindFile": "ms-resource:loc.messages.FailedToFindFile", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "2.234.0", - "Node20_229_7": "2.234.1" + "Default": "2.234.2", + "Node20_229_7": "2.234.3" } } \ No newline at end of file From bfca93f8425d86eae4da96c73884496327f24407 Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 13:11:00 +0100 Subject: [PATCH 04/11] Fail CondaEnvironmentV1 task --- Tasks/CondaEnvironmentV1/main.ts | 5 +++++ Tasks/CondaEnvironmentV1/task.json | 5 +++-- Tasks/CondaEnvironmentV1/task.loc.json | 2 +- _generated/CondaEnvironmentV1.versionmap.txt | 4 ++-- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- _generated/CondaEnvironmentV1/main.ts | 5 +++++ _generated/CondaEnvironmentV1/task.json | 9 +++++---- _generated/CondaEnvironmentV1/task.loc.json | 9 +++++---- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- _generated/CondaEnvironmentV1_Node20/main.ts | 5 +++++ _generated/CondaEnvironmentV1_Node20/task.json | 9 +++++---- _generated/CondaEnvironmentV1_Node20/task.loc.json | 9 +++++---- 12 files changed, 45 insertions(+), 23 deletions(-) diff --git a/Tasks/CondaEnvironmentV1/main.ts b/Tasks/CondaEnvironmentV1/main.ts index f7cfd3d0a31c..2d084e0af3ee 100644 --- a/Tasks/CondaEnvironmentV1/main.ts +++ b/Tasks/CondaEnvironmentV1/main.ts @@ -19,6 +19,11 @@ import { condaEnvironment } from './conda'; cleanEnvironment: task.getBoolInput('cleanEnvironment') }, getPlatform()); + let shouldFail = task.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(task.loc("DeprecatedTask")); + } task.setResult(task.TaskResult.Succeeded, ""); } catch (e) { #if NODE20 diff --git a/Tasks/CondaEnvironmentV1/task.json b/Tasks/CondaEnvironmentV1/task.json index 3f4ee52e5887..c1437da8a4b4 100644 --- a/Tasks/CondaEnvironmentV1/task.json +++ b/Tasks/CondaEnvironmentV1/task.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", @@ -101,6 +101,7 @@ "ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...", "ParameterRequired": "The `%s` parameter is required", "PlatformNotRecognized": "Platform not recognized", - "PrependPath": "Prepending PATH environment variable with directory: %s" + "PrependPath": "Prepending PATH environment variable with directory: %s", + "DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." } } \ No newline at end of file diff --git a/Tasks/CondaEnvironmentV1/task.loc.json b/Tasks/CondaEnvironmentV1/task.loc.json index 17f8a593c7ee..f075f71aec75 100644 --- a/Tasks/CondaEnvironmentV1/task.loc.json +++ b/Tasks/CondaEnvironmentV1/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", diff --git a/_generated/CondaEnvironmentV1.versionmap.txt b/_generated/CondaEnvironmentV1.versionmap.txt index 6584f283a070..43a8eb5eff57 100644 --- a/_generated/CondaEnvironmentV1.versionmap.txt +++ b/_generated/CondaEnvironmentV1.versionmap.txt @@ -1,2 +1,2 @@ -Default|1.234.0 -Node20-225|1.234.1 +Default|1.234.2 +Node20-225|1.234.3 diff --git a/_generated/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson b/_generated/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson index 2352ea09a954..74ac7b229902 100644 --- a/_generated/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson +++ b/_generated/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson @@ -24,5 +24,6 @@ "loc.messages.ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...", "loc.messages.ParameterRequired": "The `%s` parameter is required", "loc.messages.PlatformNotRecognized": "Platform not recognized", - "loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s" + "loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s", + "loc.messages.DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1/main.ts b/_generated/CondaEnvironmentV1/main.ts index 6bd77de58ee9..321d5f4a1173 100644 --- a/_generated/CondaEnvironmentV1/main.ts +++ b/_generated/CondaEnvironmentV1/main.ts @@ -16,6 +16,11 @@ import { condaEnvironment } from './conda'; cleanEnvironment: task.getBoolInput('cleanEnvironment') }, getPlatform()); + let shouldFail = task.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(task.loc("DeprecatedTask")); + } task.setResult(task.TaskResult.Succeeded, ""); } catch (e) { task.setResult(task.TaskResult.Failed, e.message); diff --git a/_generated/CondaEnvironmentV1/task.json b/_generated/CondaEnvironmentV1/task.json index 5e59c248789c..032eb4ac6df4 100644 --- a/_generated/CondaEnvironmentV1/task.json +++ b/_generated/CondaEnvironmentV1/task.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", @@ -101,10 +101,11 @@ "ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...", "ParameterRequired": "The `%s` parameter is required", "PlatformNotRecognized": "Platform not recognized", - "PrependPath": "Prepending PATH environment variable with directory: %s" + "PrependPath": "Prepending PATH environment variable with directory: %s", + "DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20-225": "1.234.1" + "Default": "1.234.2", + "Node20-225": "1.234.3" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1/task.loc.json b/_generated/CondaEnvironmentV1/task.loc.json index 2045eb23adf7..4ed6dae854a0 100644 --- a/_generated/CondaEnvironmentV1/task.loc.json +++ b/_generated/CondaEnvironmentV1/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", @@ -101,10 +101,11 @@ "ReactivateExistingEnvironment": "ms-resource:loc.messages.ReactivateExistingEnvironment", "ParameterRequired": "ms-resource:loc.messages.ParameterRequired", "PlatformNotRecognized": "ms-resource:loc.messages.PlatformNotRecognized", - "PrependPath": "ms-resource:loc.messages.PrependPath" + "PrependPath": "ms-resource:loc.messages.PrependPath", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20-225": "1.234.1" + "Default": "1.234.2", + "Node20-225": "1.234.3" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1_Node20/Strings/resources.resjson/en-US/resources.resjson b/_generated/CondaEnvironmentV1_Node20/Strings/resources.resjson/en-US/resources.resjson index 2352ea09a954..74ac7b229902 100644 --- a/_generated/CondaEnvironmentV1_Node20/Strings/resources.resjson/en-US/resources.resjson +++ b/_generated/CondaEnvironmentV1_Node20/Strings/resources.resjson/en-US/resources.resjson @@ -24,5 +24,6 @@ "loc.messages.ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...", "loc.messages.ParameterRequired": "The `%s` parameter is required", "loc.messages.PlatformNotRecognized": "Platform not recognized", - "loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s" + "loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s", + "loc.messages.DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1_Node20/main.ts b/_generated/CondaEnvironmentV1_Node20/main.ts index aef867b1603c..d84435b32f2d 100644 --- a/_generated/CondaEnvironmentV1_Node20/main.ts +++ b/_generated/CondaEnvironmentV1_Node20/main.ts @@ -17,6 +17,11 @@ import { condaEnvironment } from './conda'; cleanEnvironment: task.getBoolInput('cleanEnvironment') }, getPlatform()); + let shouldFail = task.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(task.loc("DeprecatedTask")); + } task.setResult(task.TaskResult.Succeeded, ""); } catch (e) { error = e; diff --git a/_generated/CondaEnvironmentV1_Node20/task.json b/_generated/CondaEnvironmentV1_Node20/task.json index fbe487714822..090364842837 100644 --- a/_generated/CondaEnvironmentV1_Node20/task.json +++ b/_generated/CondaEnvironmentV1_Node20/task.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "deprecated": true, "removalDate": "2024-01-31", @@ -105,10 +105,11 @@ "ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...", "ParameterRequired": "The `%s` parameter is required", "PlatformNotRecognized": "Platform not recognized", - "PrependPath": "Prepending PATH environment variable with directory: %s" + "PrependPath": "Prepending PATH environment variable with directory: %s", + "DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20-225": "1.234.1" + "Default": "1.234.2", + "Node20-225": "1.234.3" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1_Node20/task.loc.json b/_generated/CondaEnvironmentV1_Node20/task.loc.json index 7d361eaa2842..e4b338045575 100644 --- a/_generated/CondaEnvironmentV1_Node20/task.loc.json +++ b/_generated/CondaEnvironmentV1_Node20/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "deprecated": true, "removalDate": "2024-01-31", @@ -105,10 +105,11 @@ "ReactivateExistingEnvironment": "ms-resource:loc.messages.ReactivateExistingEnvironment", "ParameterRequired": "ms-resource:loc.messages.ParameterRequired", "PlatformNotRecognized": "ms-resource:loc.messages.PlatformNotRecognized", - "PrependPath": "ms-resource:loc.messages.PrependPath" + "PrependPath": "ms-resource:loc.messages.PrependPath", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20-225": "1.234.1" + "Default": "1.234.2", + "Node20-225": "1.234.3" } } \ No newline at end of file From a80f5cb0d92e75c41f659bca9dd29017828a316a Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 13:23:05 +0100 Subject: [PATCH 05/11] Fail DotNetCoreInstallerV1 task --- Tasks/DotNetCoreInstallerV1/dotnetcoreinstaller.ts | 6 ++++++ Tasks/DotNetCoreInstallerV1/task.json | 5 +++-- Tasks/DotNetCoreInstallerV1/task.loc.json | 2 +- _generated/DotNetCoreInstallerV1.versionmap.txt | 4 ++-- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- .../DotNetCoreInstallerV1_Node20/dotnetcoreinstaller.ts | 6 ++++++ _generated/DotNetCoreInstallerV1_Node20/task.json | 9 +++++---- _generated/DotNetCoreInstallerV1_Node20/task.loc.json | 9 +++++---- 8 files changed, 30 insertions(+), 14 deletions(-) diff --git a/Tasks/DotNetCoreInstallerV1/dotnetcoreinstaller.ts b/Tasks/DotNetCoreInstallerV1/dotnetcoreinstaller.ts index b3989d54e119..8bee770098ed 100644 --- a/Tasks/DotNetCoreInstallerV1/dotnetcoreinstaller.ts +++ b/Tasks/DotNetCoreInstallerV1/dotnetcoreinstaller.ts @@ -41,6 +41,12 @@ async function run() { // Set DOTNET_ROOT for dotnet core Apphost to find runtime since it is installed to a non well-known location. tl.setVariable('DOTNET_ROOT', installationPath); + + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } } function addDotNetCoreToolPath() { diff --git a/Tasks/DotNetCoreInstallerV1/task.json b/Tasks/DotNetCoreInstallerV1/task.json index 8b32fe34fbd0..2d34627847ae 100644 --- a/Tasks/DotNetCoreInstallerV1/task.json +++ b/Tasks/DotNetCoreInstallerV1/task.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", @@ -153,6 +153,7 @@ "FilesDataIsIncorrectInVersion": "In release %s for version %s, File data is incorrect (might have missing required fields, such as name, rid and url): %s", "VersionFilesDataIncorrect": "Version's files data is missing or has missing required fields.", "VersionInformationNotComplete": "Version: %s required information is not complete in releases.json file. Error: %s", - "FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s" + "FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s", + "DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead." } } \ No newline at end of file diff --git a/Tasks/DotNetCoreInstallerV1/task.loc.json b/Tasks/DotNetCoreInstallerV1/task.loc.json index 0099e3f4d228..2bb002eaca31 100644 --- a/Tasks/DotNetCoreInstallerV1/task.loc.json +++ b/Tasks/DotNetCoreInstallerV1/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 0 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", diff --git a/_generated/DotNetCoreInstallerV1.versionmap.txt b/_generated/DotNetCoreInstallerV1.versionmap.txt index e3500890f3b7..520e6ab5f71e 100644 --- a/_generated/DotNetCoreInstallerV1.versionmap.txt +++ b/_generated/DotNetCoreInstallerV1.versionmap.txt @@ -1,2 +1,2 @@ -Default|1.234.0 -Node20_229_3|1.234.1 +Default|1.234.2 +Node20_229_3|1.234.3 diff --git a/_generated/DotNetCoreInstallerV1_Node20/Strings/resources.resjson/en-US/resources.resjson b/_generated/DotNetCoreInstallerV1_Node20/Strings/resources.resjson/en-US/resources.resjson index 706457fda6d3..25a049565f25 100644 --- a/_generated/DotNetCoreInstallerV1_Node20/Strings/resources.resjson/en-US/resources.resjson +++ b/_generated/DotNetCoreInstallerV1_Node20/Strings/resources.resjson/en-US/resources.resjson @@ -78,5 +78,6 @@ "loc.messages.FilesDataIsIncorrectInVersion": "In release %s for version %s, File data is incorrect (might have missing required fields, such as name, rid and url): %s", "loc.messages.VersionFilesDataIncorrect": "Version's files data is missing or has missing required fields.", "loc.messages.VersionInformationNotComplete": "Version: %s required information is not complete in releases.json file. Error: %s", - "loc.messages.FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s" + "loc.messages.FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s", + "loc.messages.DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead." } \ No newline at end of file diff --git a/_generated/DotNetCoreInstallerV1_Node20/dotnetcoreinstaller.ts b/_generated/DotNetCoreInstallerV1_Node20/dotnetcoreinstaller.ts index b3989d54e119..8bee770098ed 100644 --- a/_generated/DotNetCoreInstallerV1_Node20/dotnetcoreinstaller.ts +++ b/_generated/DotNetCoreInstallerV1_Node20/dotnetcoreinstaller.ts @@ -41,6 +41,12 @@ async function run() { // Set DOTNET_ROOT for dotnet core Apphost to find runtime since it is installed to a non well-known location. tl.setVariable('DOTNET_ROOT', installationPath); + + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } } function addDotNetCoreToolPath() { diff --git a/_generated/DotNetCoreInstallerV1_Node20/task.json b/_generated/DotNetCoreInstallerV1_Node20/task.json index 59313f846bb5..300e910bd71a 100644 --- a/_generated/DotNetCoreInstallerV1_Node20/task.json +++ b/_generated/DotNetCoreInstallerV1_Node20/task.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "deprecated": true, "removalDate": "2024-01-31", @@ -157,10 +157,11 @@ "FilesDataIsIncorrectInVersion": "In release %s for version %s, File data is incorrect (might have missing required fields, such as name, rid and url): %s", "VersionFilesDataIncorrect": "Version's files data is missing or has missing required fields.", "VersionInformationNotComplete": "Version: %s required information is not complete in releases.json file. Error: %s", - "FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s" + "FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s", + "DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead." }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20_229_3": "1.234.1" + "Default": "1.234.2", + "Node20_229_3": "1.234.3" } } \ No newline at end of file diff --git a/_generated/DotNetCoreInstallerV1_Node20/task.loc.json b/_generated/DotNetCoreInstallerV1_Node20/task.loc.json index 7fd2fffa6a87..43d7eccb210a 100644 --- a/_generated/DotNetCoreInstallerV1_Node20/task.loc.json +++ b/_generated/DotNetCoreInstallerV1_Node20/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 1 + "Patch": 3 }, "deprecated": true, "removalDate": "2024-01-31", @@ -157,10 +157,11 @@ "FilesDataIsIncorrectInVersion": "ms-resource:loc.messages.FilesDataIsIncorrectInVersion", "VersionFilesDataIncorrect": "ms-resource:loc.messages.VersionFilesDataIncorrect", "VersionInformationNotComplete": "ms-resource:loc.messages.VersionInformationNotComplete", - "FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge" + "FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.0", - "Node20_229_3": "1.234.1" + "Default": "1.234.2", + "Node20_229_3": "1.234.3" } } \ No newline at end of file From 51d3cf598c317943720608dc30849b53ade605ba Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 15:46:02 +0100 Subject: [PATCH 06/11] Fix resjson files --- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- .../Strings/resources.resjson/en-US/resources.resjson | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Tasks/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson b/Tasks/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson index 2352ea09a954..74ac7b229902 100644 --- a/Tasks/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson +++ b/Tasks/CondaEnvironmentV1/Strings/resources.resjson/en-US/resources.resjson @@ -24,5 +24,6 @@ "loc.messages.ReactivateExistingEnvironment": "Found existing environment %s and the task's \"Clean environment\" parameter is not set. Reactivating ...", "loc.messages.ParameterRequired": "The `%s` parameter is required", "loc.messages.PlatformNotRecognized": "Platform not recognized", - "loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s" + "loc.messages.PrependPath": "Prepending PATH environment variable with directory: %s", + "loc.messages.DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." } \ No newline at end of file diff --git a/Tasks/DotNetCoreInstallerV1/Strings/resources.resjson/en-US/resources.resjson b/Tasks/DotNetCoreInstallerV1/Strings/resources.resjson/en-US/resources.resjson index 706457fda6d3..25a049565f25 100644 --- a/Tasks/DotNetCoreInstallerV1/Strings/resources.resjson/en-US/resources.resjson +++ b/Tasks/DotNetCoreInstallerV1/Strings/resources.resjson/en-US/resources.resjson @@ -78,5 +78,6 @@ "loc.messages.FilesDataIsIncorrectInVersion": "In release %s for version %s, File data is incorrect (might have missing required fields, such as name, rid and url): %s", "loc.messages.VersionFilesDataIncorrect": "Version's files data is missing or has missing required fields.", "loc.messages.VersionInformationNotComplete": "Version: %s required information is not complete in releases.json file. Error: %s", - "loc.messages.FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s" + "loc.messages.FailedWhileExtractingPacakge": "Failed while extracting downloaded package with error: %s", + "loc.messages.DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead." } \ No newline at end of file From c3d25cfca3be0ee8220b2205a4217c3209c730ec Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 15:56:36 +0100 Subject: [PATCH 07/11] fix task.loc.json files --- Tasks/CondaEnvironmentV1/task.loc.json | 7 ++++++- Tasks/DotNetCoreInstallerV1/task.loc.json | 13 +++++++++++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/Tasks/CondaEnvironmentV1/task.loc.json b/Tasks/CondaEnvironmentV1/task.loc.json index f075f71aec75..4ed6dae854a0 100644 --- a/Tasks/CondaEnvironmentV1/task.loc.json +++ b/Tasks/CondaEnvironmentV1/task.loc.json @@ -101,6 +101,11 @@ "ReactivateExistingEnvironment": "ms-resource:loc.messages.ReactivateExistingEnvironment", "ParameterRequired": "ms-resource:loc.messages.ParameterRequired", "PlatformNotRecognized": "ms-resource:loc.messages.PlatformNotRecognized", - "PrependPath": "ms-resource:loc.messages.PrependPath" + "PrependPath": "ms-resource:loc.messages.PrependPath", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" + }, + "_buildConfigMapping": { + "Default": "1.234.2", + "Node20-225": "1.234.3" } } \ No newline at end of file diff --git a/Tasks/DotNetCoreInstallerV1/task.loc.json b/Tasks/DotNetCoreInstallerV1/task.loc.json index 2bb002eaca31..43d7eccb210a 100644 --- a/Tasks/DotNetCoreInstallerV1/task.loc.json +++ b/Tasks/DotNetCoreInstallerV1/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 2 + "Patch": 3 }, "deprecated": true, "removalDate": "2024-01-31", @@ -87,6 +87,10 @@ }, "Node16": { "target": "dotnetcoreinstaller.js" + }, + "Node20_1": { + "target": "dotnetcoreinstaller.js", + "argumentFormat": "" } }, "messages": { @@ -153,6 +157,11 @@ "FilesDataIsIncorrectInVersion": "ms-resource:loc.messages.FilesDataIsIncorrectInVersion", "VersionFilesDataIncorrect": "ms-resource:loc.messages.VersionFilesDataIncorrect", "VersionInformationNotComplete": "ms-resource:loc.messages.VersionInformationNotComplete", - "FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge" + "FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge", + "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" + }, + "_buildConfigMapping": { + "Default": "1.234.2", + "Node20_229_3": "1.234.3" } } \ No newline at end of file From 45e6ef504e999e6d2b7a0107ecd478668fe9c12c Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 16:06:44 +0100 Subject: [PATCH 08/11] fix app center distribute v1 task --- .../appcenterdistribute.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts b/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts index 460843ee5e03..6742d8e9a352 100644 --- a/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts +++ b/_generated/AppCenterDistributeV1_Node20/appcenterdistribute.ts @@ -445,12 +445,6 @@ async function run() { try { tl.setResourcePath(path.join(__dirname, 'task.json')); - let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); - - if (shouldFail != null && shouldFail.toLowerCase() === 'true') { - throw new Error(tl.loc("DeprecatedTask")); - } - // Get build inputs let apiEndpointData = getEndpointDetails('serverEndpoint'); let apiToken: string = apiEndpointData.authToken; @@ -564,6 +558,12 @@ async function run() { await commitSymbols(effectiveApiServer, effectiveApiVersion, appSlug, symbolsUploadInfo.symbol_upload_id, apiToken, userAgent); } + let shouldFail = tl.getVariable('FAIL_DEPRECATED_BUILD_TASK'); + + if (shouldFail != null && shouldFail.toLowerCase() === 'true') { + throw new Error(tl.loc("DeprecatedTask")); + } + tl.setResult(tl.TaskResult.Succeeded, tl.loc("Succeeded")); } catch (err) { tl.setResult(tl.TaskResult.Failed, `${err}`); From 41daf6050516b48860d7c0b630f677bfb0f5e913 Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 16:12:29 +0100 Subject: [PATCH 09/11] fix --- Tasks/DotNetCoreInstallerV1/task.loc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Tasks/DotNetCoreInstallerV1/task.loc.json b/Tasks/DotNetCoreInstallerV1/task.loc.json index 43d7eccb210a..8e76f8e54845 100644 --- a/Tasks/DotNetCoreInstallerV1/task.loc.json +++ b/Tasks/DotNetCoreInstallerV1/task.loc.json @@ -14,7 +14,7 @@ "version": { "Major": 1, "Minor": 234, - "Patch": 3 + "Patch": 2 }, "deprecated": true, "removalDate": "2024-01-31", From 52ae10377b2bce277751f185babaf6f3eadf01db Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Thu, 25 Jan 2024 16:21:35 +0100 Subject: [PATCH 10/11] fix tests --- Tasks/DotNetCoreInstallerV1/task.loc.json | 8 -------- 1 file changed, 8 deletions(-) diff --git a/Tasks/DotNetCoreInstallerV1/task.loc.json b/Tasks/DotNetCoreInstallerV1/task.loc.json index 8e76f8e54845..52b794fe3ac1 100644 --- a/Tasks/DotNetCoreInstallerV1/task.loc.json +++ b/Tasks/DotNetCoreInstallerV1/task.loc.json @@ -87,10 +87,6 @@ }, "Node16": { "target": "dotnetcoreinstaller.js" - }, - "Node20_1": { - "target": "dotnetcoreinstaller.js", - "argumentFormat": "" } }, "messages": { @@ -159,9 +155,5 @@ "VersionInformationNotComplete": "ms-resource:loc.messages.VersionInformationNotComplete", "FailedWhileExtractingPacakge": "ms-resource:loc.messages.FailedWhileExtractingPacakge", "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" - }, - "_buildConfigMapping": { - "Default": "1.234.2", - "Node20_229_3": "1.234.3" } } \ No newline at end of file From c0e8c01acc470ae490f7077aeeef67032eebf1e0 Mon Sep 17 00:00:00 2001 From: Pranshu-Negi Date: Fri, 26 Jan 2024 10:40:02 +0100 Subject: [PATCH 11/11] bump task version --- Tasks/AppCenterDistributeV1/task.json | 4 ++-- Tasks/AppCenterDistributeV1/task.loc.json | 4 ++-- Tasks/AppCenterDistributeV2/task.json | 4 ++-- Tasks/AppCenterDistributeV2/task.loc.json | 4 ++-- Tasks/CondaEnvironmentV1/task.json | 4 ++-- Tasks/CondaEnvironmentV1/task.loc.json | 4 ++-- Tasks/DotNetCoreInstallerV1/task.json | 4 ++-- Tasks/DotNetCoreInstallerV1/task.loc.json | 4 ++-- _generated/AppCenterDistributeV1.versionmap.txt | 4 ++-- _generated/AppCenterDistributeV1_Node20/task.json | 8 ++++---- _generated/AppCenterDistributeV1_Node20/task.loc.json | 8 ++++---- _generated/AppCenterDistributeV2.versionmap.txt | 4 ++-- _generated/AppCenterDistributeV2_Node20/task.json | 8 ++++---- _generated/AppCenterDistributeV2_Node20/task.loc.json | 8 ++++---- _generated/CondaEnvironmentV1.versionmap.txt | 4 ++-- _generated/CondaEnvironmentV1/task.json | 8 ++++---- _generated/CondaEnvironmentV1/task.loc.json | 8 ++++---- _generated/CondaEnvironmentV1_Node20/task.json | 8 ++++---- _generated/CondaEnvironmentV1_Node20/task.loc.json | 8 ++++---- _generated/DotNetCoreInstallerV1.versionmap.txt | 4 ++-- _generated/DotNetCoreInstallerV1_Node20/task.json | 8 ++++---- _generated/DotNetCoreInstallerV1_Node20/task.loc.json | 8 ++++---- 22 files changed, 64 insertions(+), 64 deletions(-) diff --git a/Tasks/AppCenterDistributeV1/task.json b/Tasks/AppCenterDistributeV1/task.json index 07c616c22f0a..79f0701d7155 100644 --- a/Tasks/AppCenterDistributeV1/task.json +++ b/Tasks/AppCenterDistributeV1/task.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Fix bug where feature branches were being truncated.", diff --git a/Tasks/AppCenterDistributeV1/task.loc.json b/Tasks/AppCenterDistributeV1/task.loc.json index 8925f9f41e61..3ad7a018bd43 100644 --- a/Tasks/AppCenterDistributeV1/task.loc.json +++ b/Tasks/AppCenterDistributeV1/task.loc.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", diff --git a/Tasks/AppCenterDistributeV2/task.json b/Tasks/AppCenterDistributeV2/task.json index 78011f5248ab..96d662b08ddb 100644 --- a/Tasks/AppCenterDistributeV2/task.json +++ b/Tasks/AppCenterDistributeV2/task.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 2, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Added support for multiple destinations.", diff --git a/Tasks/AppCenterDistributeV2/task.loc.json b/Tasks/AppCenterDistributeV2/task.loc.json index cef72c8e15eb..acf7b5407c68 100644 --- a/Tasks/AppCenterDistributeV2/task.loc.json +++ b/Tasks/AppCenterDistributeV2/task.loc.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 2, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", diff --git a/Tasks/CondaEnvironmentV1/task.json b/Tasks/CondaEnvironmentV1/task.json index c1437da8a4b4..256fb105599c 100644 --- a/Tasks/CondaEnvironmentV1/task.json +++ b/Tasks/CondaEnvironmentV1/task.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "deprecated": true, "removalDate": "2024-01-31", diff --git a/Tasks/CondaEnvironmentV1/task.loc.json b/Tasks/CondaEnvironmentV1/task.loc.json index 4ed6dae854a0..dde84a5aa260 100644 --- a/Tasks/CondaEnvironmentV1/task.loc.json +++ b/Tasks/CondaEnvironmentV1/task.loc.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "deprecated": true, "removalDate": "2024-01-31", diff --git a/Tasks/DotNetCoreInstallerV1/task.json b/Tasks/DotNetCoreInstallerV1/task.json index 2d34627847ae..4d8f543063a3 100644 --- a/Tasks/DotNetCoreInstallerV1/task.json +++ b/Tasks/DotNetCoreInstallerV1/task.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "deprecated": true, "removalDate": "2024-01-31", diff --git a/Tasks/DotNetCoreInstallerV1/task.loc.json b/Tasks/DotNetCoreInstallerV1/task.loc.json index 52b794fe3ac1..14e7a158132b 100644 --- a/Tasks/DotNetCoreInstallerV1/task.loc.json +++ b/Tasks/DotNetCoreInstallerV1/task.loc.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "deprecated": true, "removalDate": "2024-01-31", diff --git a/_generated/AppCenterDistributeV1.versionmap.txt b/_generated/AppCenterDistributeV1.versionmap.txt index 3e5f935ff138..bf340ca139ef 100644 --- a/_generated/AppCenterDistributeV1.versionmap.txt +++ b/_generated/AppCenterDistributeV1.versionmap.txt @@ -1,2 +1,2 @@ -Default|1.234.2 -Node20_229_7|1.234.3 +Default|1.235.0 +Node20_229_7|1.235.1 diff --git a/_generated/AppCenterDistributeV1_Node20/task.json b/_generated/AppCenterDistributeV1_Node20/task.json index c9c106ff9891..228767bdfa8d 100644 --- a/_generated/AppCenterDistributeV1_Node20/task.json +++ b/_generated/AppCenterDistributeV1_Node20/task.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Fix bug where feature branches were being truncated.", @@ -209,7 +209,7 @@ "DeprecatedTask": "The AppCenterDistribute@1 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20_229_7": "1.234.3" + "Default": "1.235.0", + "Node20_229_7": "1.235.1" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV1_Node20/task.loc.json b/_generated/AppCenterDistributeV1_Node20/task.loc.json index acb5d47ff1c2..4b88e72ba053 100644 --- a/_generated/AppCenterDistributeV1_Node20/task.loc.json +++ b/_generated/AppCenterDistributeV1_Node20/task.loc.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", @@ -209,7 +209,7 @@ "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20_229_7": "1.234.3" + "Default": "1.235.0", + "Node20_229_7": "1.235.1" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV2.versionmap.txt b/_generated/AppCenterDistributeV2.versionmap.txt index 70efee6e7aad..5bb6442d61ff 100644 --- a/_generated/AppCenterDistributeV2.versionmap.txt +++ b/_generated/AppCenterDistributeV2.versionmap.txt @@ -1,2 +1,2 @@ -Default|2.234.2 -Node20_229_7|2.234.3 +Default|2.235.0 +Node20_229_7|2.235.1 diff --git a/_generated/AppCenterDistributeV2_Node20/task.json b/_generated/AppCenterDistributeV2_Node20/task.json index f3a11d8546e4..3848df20dfe5 100644 --- a/_generated/AppCenterDistributeV2_Node20/task.json +++ b/_generated/AppCenterDistributeV2_Node20/task.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 2, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "Added support for multiple destinations.", @@ -211,7 +211,7 @@ "DeprecatedTask": "The AppCenterDistribute@2 (App Center distribute) task has been deprecated since November 14, 2022 and will soon be retired. Use the AppCenterDistribute@3 task instead." }, "_buildConfigMapping": { - "Default": "2.234.2", - "Node20_229_7": "2.234.3" + "Default": "2.235.0", + "Node20_229_7": "2.235.1" } } \ No newline at end of file diff --git a/_generated/AppCenterDistributeV2_Node20/task.loc.json b/_generated/AppCenterDistributeV2_Node20/task.loc.json index a3ced2653a9a..72de3386fd19 100644 --- a/_generated/AppCenterDistributeV2_Node20/task.loc.json +++ b/_generated/AppCenterDistributeV2_Node20/task.loc.json @@ -16,8 +16,8 @@ "author": "Microsoft Corporation", "version": { "Major": 2, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "minimumAgentVersion": "2.144.0", "releaseNotes": "ms-resource:loc.releaseNotes", @@ -211,7 +211,7 @@ "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "2.234.2", - "Node20_229_7": "2.234.3" + "Default": "2.235.0", + "Node20_229_7": "2.235.1" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1.versionmap.txt b/_generated/CondaEnvironmentV1.versionmap.txt index 43a8eb5eff57..26181367ed1e 100644 --- a/_generated/CondaEnvironmentV1.versionmap.txt +++ b/_generated/CondaEnvironmentV1.versionmap.txt @@ -1,2 +1,2 @@ -Default|1.234.2 -Node20-225|1.234.3 +Default|1.235.0 +Node20-225|1.235.1 diff --git a/_generated/CondaEnvironmentV1/task.json b/_generated/CondaEnvironmentV1/task.json index 032eb4ac6df4..48948eb4c677 100644 --- a/_generated/CondaEnvironmentV1/task.json +++ b/_generated/CondaEnvironmentV1/task.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "deprecated": true, "removalDate": "2024-01-31", @@ -105,7 +105,7 @@ "DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20-225": "1.234.3" + "Default": "1.235.0", + "Node20-225": "1.235.1" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1/task.loc.json b/_generated/CondaEnvironmentV1/task.loc.json index 4ed6dae854a0..c7dfb5c58d09 100644 --- a/_generated/CondaEnvironmentV1/task.loc.json +++ b/_generated/CondaEnvironmentV1/task.loc.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 2 + "Minor": 235, + "Patch": 0 }, "deprecated": true, "removalDate": "2024-01-31", @@ -105,7 +105,7 @@ "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20-225": "1.234.3" + "Default": "1.235.0", + "Node20-225": "1.235.1" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1_Node20/task.json b/_generated/CondaEnvironmentV1_Node20/task.json index 090364842837..942a8652c533 100644 --- a/_generated/CondaEnvironmentV1_Node20/task.json +++ b/_generated/CondaEnvironmentV1_Node20/task.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "deprecated": true, "removalDate": "2024-01-31", @@ -109,7 +109,7 @@ "DeprecatedTask": "The CondaEnvironment@1 (Conda environment) task has been deprecated since February 13, 2019 and will soon be retired. Use the Conda CLI ('conda') directly from a bash/pwsh/script task." }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20-225": "1.234.3" + "Default": "1.235.0", + "Node20-225": "1.235.1" } } \ No newline at end of file diff --git a/_generated/CondaEnvironmentV1_Node20/task.loc.json b/_generated/CondaEnvironmentV1_Node20/task.loc.json index e4b338045575..3dea60551c5f 100644 --- a/_generated/CondaEnvironmentV1_Node20/task.loc.json +++ b/_generated/CondaEnvironmentV1_Node20/task.loc.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "deprecated": true, "removalDate": "2024-01-31", @@ -109,7 +109,7 @@ "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20-225": "1.234.3" + "Default": "1.235.0", + "Node20-225": "1.235.1" } } \ No newline at end of file diff --git a/_generated/DotNetCoreInstallerV1.versionmap.txt b/_generated/DotNetCoreInstallerV1.versionmap.txt index 520e6ab5f71e..6f666948200c 100644 --- a/_generated/DotNetCoreInstallerV1.versionmap.txt +++ b/_generated/DotNetCoreInstallerV1.versionmap.txt @@ -1,2 +1,2 @@ -Default|1.234.2 -Node20_229_3|1.234.3 +Default|1.235.0 +Node20_229_3|1.235.1 diff --git a/_generated/DotNetCoreInstallerV1_Node20/task.json b/_generated/DotNetCoreInstallerV1_Node20/task.json index 300e910bd71a..333102c00f70 100644 --- a/_generated/DotNetCoreInstallerV1_Node20/task.json +++ b/_generated/DotNetCoreInstallerV1_Node20/task.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "deprecated": true, "removalDate": "2024-01-31", @@ -161,7 +161,7 @@ "DeprecatedTask": "The DotNetCoreInstaller@1 (.NET Core SDK/runtime installer) task has been deprecated since August 22, 2019 and will soon be retired. Use the UseDotNet@2 task instead." }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20_229_3": "1.234.3" + "Default": "1.235.0", + "Node20_229_3": "1.235.1" } } \ No newline at end of file diff --git a/_generated/DotNetCoreInstallerV1_Node20/task.loc.json b/_generated/DotNetCoreInstallerV1_Node20/task.loc.json index 43d7eccb210a..b370b92b7d74 100644 --- a/_generated/DotNetCoreInstallerV1_Node20/task.loc.json +++ b/_generated/DotNetCoreInstallerV1_Node20/task.loc.json @@ -13,8 +13,8 @@ "author": "Microsoft Corporation", "version": { "Major": 1, - "Minor": 234, - "Patch": 3 + "Minor": 235, + "Patch": 1 }, "deprecated": true, "removalDate": "2024-01-31", @@ -161,7 +161,7 @@ "DeprecatedTask": "ms-resource:loc.messages.DeprecatedTask" }, "_buildConfigMapping": { - "Default": "1.234.2", - "Node20_229_3": "1.234.3" + "Default": "1.235.0", + "Node20_229_3": "1.235.1" } } \ No newline at end of file