Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machines no longer uses machine group properly #866

Closed
blsher opened this issue Nov 24, 2015 · 9 comments
Closed

Machines no longer uses machine group properly #866

blsher opened this issue Nov 24, 2015 · 9 comments

Comments

@blsher
Copy link

blsher commented Nov 24, 2015

Windows Machine File Copy doesn't work anymore.

[machinegroup] by itself doesn't work, [machinegroup], [machinename] doesn't work. [machinename] doesn't work.

The interface doesn't mask passwords.

Agent 1.91.1 and windows machine file copy 1.0.14.

All my builds are affected, and i'm on edge about any changes could break the lot. (25+ builds).

2015-11-24T18:49:45.9632817Z Executing the powershell script: D:\Agent_P_BC_01_5\tasks\WindowsMachineFileCopy\1.0.14\WindowsMachineFileCopy.ps1
2015-11-24T18:49:46.0726626Z ##[debug]Entering script WindowsMachineFileCopy.ps1
2015-11-24T18:49:46.0726626Z ##[debug]environmentName = q-web-01.domain.com, 2012 R2 QA
2015-11-24T18:49:46.0726626Z ##[debug]adminUserName =
2015-11-24T18:49:46.0726626Z ##[debug]resourceFilteringMethod = machineNames
2015-11-24T18:49:46.0726626Z ##[debug]machineNames =
2015-11-24T18:49:46.0726626Z ##[debug]sourcePath = D:\Agent_P_BC_01_5_work\1\a_PublishedWebsites\admin
2015-11-24T18:49:46.0726626Z ##[debug]targetPath = D:\websites\deploy
2015-11-24T18:49:46.0726626Z ##[debug]additionalArguments =
2015-11-24T18:49:46.0726626Z ##[debug]copyFilesInParallel = true
2015-11-24T18:49:46.0882884Z ##[debug]cleanTargetBeforeCopy = false
2015-11-24T18:49:46.9634361Z ##[debug]Starting Register-Environment cmdlet call for environment : q-web-01.domain.com, 2012 R2 QA with filter
2015-11-24T18:49:49.6669636Z ##[debug]Completed Register-Environment cmdlet call for environment : q-web-01.domain.com, 2012 R2 QA
2015-11-24T18:49:49.6825842Z ##[debug]Starting Get-EnvironmentResources cmdlet call on environment name: q-web-01.domain.com, 2012 R2 QA
2015-11-24T18:49:49.6982509Z ##[debug]Completed Get-EnvironmentResources cmdlet call for environment name: q-web-01.domain.com, 2012 R2 QA
2015-11-24T18:49:49.7763495Z ##[debug]Get Resource properties for q-web-01.domain.com (ResourceId = 1)
2015-11-24T18:49:49.7763495Z ##[debug] Starting Get-EnvironmentProperty cmdlet call on environment name: q-web-01.domain.com, 2012 R2 QA with resource id: 1(Name : q-web-01.domain.com) and key: Microsoft-Vslabs-MG-Resource-FQDN
2015-11-24T18:49:49.7919768Z ##[debug] Completed Get-EnvironmentProperty cmdlet call on environment name: q-web-01.domain.com, 2012 R2 QA with resource id: 1(Name : q-web-01.domain.com) and key: Microsoft-Vslabs-MG-Resource-FQDN
2015-11-24T18:49:49.7919768Z ##[debug] Resource fqdn - q-web-01.domain.com
2015-11-24T18:49:49.8544877Z ##[error]Please specify valid username for resource q-web-01.domain.com

@blsher
Copy link
Author

blsher commented Nov 24, 2015

It seems like the build itself, saves the old "Filter", w here i'd pick "machine group", then put the machine name in.

Am i going to break builds if i change steps? WE're kind of reliant on this.

@blsher
Copy link
Author

blsher commented Nov 24, 2015

2015-11-23T21:03:14.7150943Z ##[debug]environmentName = 2012 R2 QA
2015-11-23T21:03:14.7150943Z ##[debug]adminUserName =
2015-11-23T21:03:14.7150943Z ##[debug]resourceFilteringMethod = machineNames
2015-11-23T21:03:14.7150943Z ##[debug]machineNames = q-web-01.domain.com

This is in a build, BEFORE your admin/password update to the screen.

So, anything that is currently working still has machineNames populated. The new coma, delimited machine name box, just seems faulty with the machine group user and pass.

This was going along really well for weeks, until a few days ago.

@blsher
Copy link
Author

blsher commented Nov 24, 2015

image

Password is in clear text, and i can't get this to pick up username and password from machine group. I can't enter passwords per step.

@blsher
Copy link
Author

blsher commented Nov 24, 2015

If i use the machine group by itself, it defaults to all servers within that group and uses the machine group.

So as a work around i guess i'm going to have to create 1 machine group per server. As it copies to all of them... it worked better before with a filter.

rage

@blsher
Copy link
Author

blsher commented Nov 25, 2015

776988e?diff=split

It looks like this changeset, removed a ton of code. With no subsequent replacement.

@RoopeshNair
Copy link
Member

Hosted Agents are due for an upgrade, I presume the issues you've quoted above are related to Hosted Agents. This should get fixed soon. As a workaround you can download the latest agent bits and setup an on-prem agent.

Regarding the issues mentioned above:
#1. Windows Machine File Copy should work with Machine Groups as before.
#2. Providing inline list of flat machines is an additional capability with this task. If you do specify inline, then you need to provide credentials. With this option, you can target only those set of machines you intend to.
#3. You can define secure variables in Build and refer to $(passwordVariable) as input to the password field to address password mask requirement.
#4. If you had filters defined in the Build Definition, it should continue to work as before. i.e. it will target only the filtered list of machines for the action. We will address the filter requirements in subsequent deployments.

@blsher
Copy link
Author

blsher commented Nov 25, 2015

All the issues i'm having is On Prem.

@RoopeshNair
Copy link
Member

@Bisher

Please try following:

  1. Ensure you've the latest version of agent. (1.91.1)
  2. In Windows File Copy Task
    Machines: <Machine Group Name> // sans '>'
    Admin login: blank
    Password: blank
    //Admin login and password details would be fetched from Machine Group definition under "Test" hub

Let us know if you're still running into issues

@blsher
Copy link
Author

blsher commented Dec 1, 2015

Closing this for resolution on a different item, this one is the smiliar problem there is no filter ability at the moment and was indicated for a fix somewhere else.

#849

@blsher blsher closed this as completed Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants