FindMatch() not working if pattern contains box bracket characters

[vinodkumar3]

Please check our current Issues to see if someone already reported this https://github.com/Microsoft/azure-pipelines-task-lib/issues

Environment

azure-pipelines-task-lib version: 2.8.0

Issue Description

FindMatch() is unable to find matching pattern if input pattern contains box bracket ('[' or ']') characters.

Logs

Logs are attached with this issue.

[damccorm]

We use minimatch to find things. I believe [ and ] are special characters, so escaping should fix the problem

[vinodkumar3]

@damccorm
Tried modifying the task and found out that in case of special characters, escaping is working with Ubuntu agents but not with Windows. Seems something related to back or forward slashes in file paths.
I can see a related issue NuGet/Home#3584 with Glob pattern.

[damccorm]

Could you share your repro? Minimatch should be able to handle that I believe, if I'm understanding the issue correctly.

[damccorm]

@vinodkumar3 any update?

[vinodkumar3]

PFA logs with updated ARM task (added modification of escaping special characters in file path, '[' & ']' in this example) where Ubuntu is correctly finding the path but Windows doesn't.

ububtu-escape.zip
windows-escape.zip

[damccorm]

It looks to me like you're escaping incorrectly on windows.
On Ubuntu, the pattern is: /home/vsts/work/1/s/a \[abc\] Subscription Deploy/resourcegroup.json
On windows, its: d:\a\1\s\a \[abc\] Subscription Deploy\resourcegroup.json

Note that in the windows version, the way you currently have it escaped there's no way to distinguish between a path seperator (\) and the escaping backslash.

With that said, escaping minimatch on Windows is weird, see - isaacs/node-glob#212. We have docs on how to do this here.

[vinodkumar3]

@damccorm
Thanks for pointing me to the right documentation. This is something I was missing. You may close the issue now.