Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Get Projects Args ] - Wrong type of ContinuationToken in SDK, it should be string not int #131

Open
xuzhang3 opened this issue May 16, 2023 · 3 comments

Comments

@xuzhang3
Copy link
Contributor

Wrong type of ContinuationToken in SDK, it should be string not int
SDK v7:
https://github.com/microsoft/azure-devops-go-api/blob/dev/azuredevops/v7/core/client.go#L548
Swagger v7:
https://github.com/MicrosoftDocs/vsts-rest-api-specs/blob/master/specification/core/7.1/core.json#L228

@nechvatalp
Copy link
Collaborator

Hi @xuzhang3 unfortunately the owners of the projects API changed this type to int recently, the specs are not fully up to date. In the current specs from which I generated the clients it looks like this:

          {
            "in": "query",
            "name": "continuationToken",
            "description": "Pointer that shows how many projects already been fetched.",
            "required": false,
            "type": "integer",
            "format": "int32"
          },

@xuzhang3
Copy link
Contributor Author

@nechvatalp thanks for the update

@xuzhang3
Copy link
Contributor Author

@nechvatalp GetProjectsResponseValue.ContinuationToken should also change to int type
https://github.com/microsoft/azure-devops-go-api/blob/dev/azuredevops/v7/core/client.go#L556

@xuzhang3 xuzhang3 reopened this May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants