-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot add Kubernetes resource #116
Comments
@nechvatalp Can you fix this SDK bug? |
@croemmich / @xuzhang3 I get the same 500 if |
@TheItalian I get the request body by browser dev tools. |
@xuzhang3 sneaky! Ok, so docs needs to be update too seems like. Gonna create an issue there as well. |
@theitalianz I didn't test all the ways to create it, from the swagger doc there should be 3 ways to create a new environment. |
Thanks for taking a look at this @theitalianz and @xuzhang3! |
@croemmich @theitalianz @xuzhang3 Please make sure swagger files are also updates - reference documents published on Docs will reflect what's defined in the swagger files. |
@croemmich Thanks for reporting, it actually should accept |
@nechvatalp, @xuzhang3, I don't think This DOES NOT work:
Returns:
This is the request body I need to make:
Of note, none of the Kubernetes Resource endpoints are documented even remotely correctly. I had to capture the network requests from the "Add resource" flow in the UI to figure out how to properly call the endpoint. The payload represented by |
@nechvatalp, @theitalianz, @kexugit any update on this issue, it's remain open for the past 6 months no one seems to take any action or decision on this issue. There're more than one providers depending on this issue resolution. Appreciate your help in a timely manner. |
Sorry, unfortunately I don't have enough time to properly maintain this repository. It comes down to priorities I have other work which is considered higher priority. I am trying to push on our PMs and management to invest more into our API clients as I would personally love to have them properly taken care of but so far, I was unsuccessful. |
Attempted to fix this issue in the upcoming 7.1 release. I split the method in two I don't have any environment to test it but I guess I can't make it worse. Commit with the change f4a4ff5 |
This should be fixed in the latest 7.1 release. |
azure-devops-go-api/azuredevops/v6/taskagent/client.go
Line 352 in 00dac5c
provides no means of supplying a
serviceEndpointId
. This makes it impossible to use with out receiving a 500 from the server with:The
AddKubernetesResourceArgs
:azure-devops-go-api/azuredevops/v6/taskagent/client.go
Line 384 in 00dac5c
should probably take a:
azure-devops-go-api/azuredevops/v6/taskagent/models.go
Line 964 in 00dac5c
instead of the current:
azure-devops-go-api/azuredevops/v6/taskagent/models.go
Line 956 in 00dac5c
The text was updated successfully, but these errors were encountered: