Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MagenticOneGroupChat to AGS #4595

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Add MagenticOneGroupChat to AGS #4595

merged 8 commits into from
Dec 9, 2024

Conversation

husseinmozannar
Copy link
Contributor

@husseinmozannar husseinmozannar commented Dec 6, 2024

Add MagenticOneGroupChat to Autogen Studio.

Remaining issues:

  • markdown rendering of Orchestrator messages
  • code blocks for the coder and other agents (possibly fixed with the markdown)
  • adding code execution agent to complete magentic one
  • have option to hide side view of agent graph so you can focus on agent messages (I think by default the graph should be hidden, but not a big deal)
image image

@husseinmozannar
Copy link
Contributor Author

Testing config

{
"version": "1.0.0",
"component_type": "team",
"name": "m1_team",
"participants": [
{
"component_type": "agent",
"name": "writing_agent",
"agent_type": "AssistantAgent",
"system_message": "You are a helpful assistant. Solve tasks carefully. When done respond with TERMINATE",
"model_client": {
"component_type": "model",
"model": "gpt-4o-2024-08-06",
"model_type": "OpenAIChatCompletionClient"
}
},
{
"component_type": "agent",
"name": "websurfer_agent",
"agent_type": "MultimodalWebSurfer",
"model_client": {
"component_type": "model",
"model": "gpt-4o-2024-08-06",
"model_type": "OpenAIChatCompletionClient"
},
"headless": false,
"logs_dir": "logs",
"downloads_folder": "logs",
"to_save_screenshots": false,
"use_ocr": false,
"animate_actions": false
}
],
"team_type": "MagenticOneGroupChat",
"model_client": {
"component_type": "model",
"model": "gpt-4o-2024-08-06",
"model_type": "OpenAIChatCompletionClient"
},
"max_turns": 3
}

@husseinmozannar husseinmozannar marked this pull request as ready for review December 7, 2024 02:27
@husseinmozannar
Copy link
Contributor Author

Fixes to connection.py are crucial to avoid typing errors that look like:

Message formatting error: Subscripted generics cannot be used with class and instance checks
Stream error for run bf7aa248-c9bc-430d-b5fa-6d7cc657396f: Subscripted generics cannot be used with class and instance checks

it is the order of checking isinstance, it is a bit weird

Copy link
Collaborator

@victordibia victordibia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @husseinmozannar .

Merging this in ..
Will make some minor fixes to visuals for the m1 orchestrator node in the node flow diagram later.

At somepoint, once we have implemented #4439 ... we can refactor component_factory to use that mechanism (we will need to refactor M1 orchestrator and agents to implement their own serialization and loading methods).

@victordibia victordibia merged commit 3817b8d into main Dec 9, 2024
45 checks passed
@victordibia victordibia deleted the magentic_one_ags branch December 9, 2024 05:44
rysweet pushed a commit that referenced this pull request Dec 10, 2024
* add magenticonegroupchat to ags

* fix termination condition

* typing order check

* format error

* fix M1 orchestrator handle tool mesages

* add filesurfer and coder
ekzhu pushed a commit that referenced this pull request Dec 10, 2024
* add magenticonegroupchat to ags

* fix termination condition

* typing order check

* format error

* fix M1 orchestrator handle tool mesages

* add filesurfer and coder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Magentic-One Orchestrator to AutoGen Studio
2 participants