Add user proxy docs. Make user proxy's default impl cancellable #4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgerrits
requested changes
Dec 2, 2024
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
Outdated
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
Show resolved
Hide resolved
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
Show resolved
Hide resolved
python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb
Show resolved
Hide resolved
...gentchat/src/autogen_agentchat/teams/_group_chat/_magentic_one/_magentic_one_orchestrator.py
Outdated
Show resolved
Hide resolved
jackgerrits
reviewed
Dec 2, 2024
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
Outdated
Show resolved
Hide resolved
jackgerrits
reviewed
Dec 2, 2024
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py
Outdated
Show resolved
Hide resolved
Contributor
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (2)
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py:110
- The phrase 'a this agent' should be 'this agent'.
It is strongly advised that a this agent be coupled with a timeout mechanic and that all errors and exceptions emanating from it are handled.
python/packages/autogen-agentchat/src/autogen_agentchat/agents/_user_proxy_agent.py:101
- The
cancellation_tokenis redefined within the function. It should use thetokendefined outside the function.
cancellation_token=CancellationToken(),
python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb
Outdated
Show resolved
Hide resolved
…r-guide/tutorial/agents.ipynb Co-authored-by: Copilot <[email protected]>
peterychang
commented
Dec 6, 2024
python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb
Outdated
Show resolved
Hide resolved
…r-guide/tutorial/agents.ipynb
jackgerrits
approved these changes
Dec 6, 2024
rysweet
pushed a commit
that referenced
this pull request
Dec 10, 2024
* Add user proxy docs. Make user proxy's default impl cancellable * remove unnecessary import * revert accidental change * address PR comments * uv sync * Fix bugs * poe format * fixing mypy issues * poe format * ignore pyright errors for ainput * fix example code * remove unused import * fix accidental reversion, example code * formatting * fix typing * Update python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb Co-authored-by: Copilot <[email protected]> * Update python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb --------- Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Eric Zhu <[email protected]>
ekzhu
added a commit
that referenced
this pull request
Dec 10, 2024
* Add user proxy docs. Make user proxy's default impl cancellable * remove unnecessary import * revert accidental change * address PR comments * uv sync * Fix bugs * poe format * fixing mypy issues * poe format * ignore pyright errors for ainput * fix example code * remove unused import * fix accidental reversion, example code * formatting * fix typing * Update python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb Co-authored-by: Copilot <[email protected]> * Update python/packages/autogen-core/docs/src/user-guide/agentchat-user-guide/tutorial/agents.ipynb --------- Co-authored-by: Jack Gerrits <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Eric Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4332