Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if use_docker evaluates to True but the python docker package is not available. #172

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Warn if use_docker evaluates to True but the python docker package is not available. #172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16351ad
Display a warning if use_docker evlauates to True but the python dock…
afourney Oct 9, 2023
174c1eb
Merge branch 'main' into warn_if_python_docker_is_na
qingyun-wu Oct 9, 2023
24551fd
Merge branch 'main' into warn_if_python_docker_is_na
qingyun-wu Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion autogen/code_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def execute_code(
timeout: Optional[int] = None,
filename: Optional[str] = None,
work_dir: Optional[str] = None,
use_docker: Optional[Union[List[str], str, bool]] = docker is not None,
use_docker: Optional[Union[List[str], str, bool]] = True,
lang: Optional[str] = "python",
) -> Tuple[int, str, str]:
"""Execute code in a docker container.
Expand Down Expand Up @@ -257,6 +257,15 @@ def execute_code(
logger.error(error_msg)
raise AssertionError(error_msg)

# Warn if docker was requested but cannot be provided. In this case
# the current behavior is to fall back to run natively, but this behavior
# is subject to change.
if use_docker and docker is None:
use_docker = False
logger.warning(
"execute_code was called with use_docker evaluating to True, but the python docker package is not available. Falling back to native code execution. Note: this fallback behavior is subject to change"
)

timeout = timeout or DEFAULT_TIMEOUT
original_filename = filename
if WIN32 and lang in ["sh", "shell"] and (not use_docker):
Expand Down
Loading