Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename retrieve chat #147

Closed
wants to merge 2 commits into from
Closed

Rename retrieve chat #147

wants to merge 2 commits into from

Conversation

thinkall
Copy link
Collaborator

@thinkall thinkall commented Oct 8, 2023

Why are these changes needed?

Address issue #23

The current naming is not perfect, it would be better to use RAG rather than Retrieve. My only concern is that this PR would be a breaking change to the RetrieveChat APIs.

Waiting till stable, then maybe move from contrib to core and rename it.

Related issue number

Closes #23

Checks

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #147 (7b79fda) into main (5ff85a3) will not change coverage.
The diff coverage is 9.37%.

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage   41.03%   41.03%           
=======================================
  Files          17       17           
  Lines        2091     2091           
  Branches      469      469           
=======================================
  Hits          858      858           
  Misses       1156     1156           
  Partials       77       77           
Flag Coverage Δ
unittests 40.93% <9.37%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
autogen/rag_utils.py 63.69% <ø> (ø)
autogen/agentchat/contrib/rag_assistant_agent.py 33.33% <66.66%> (ø)
autogen/agentchat/contrib/rag_user_proxy_agent.py 4.41% <3.44%> (ø)

@thinkall thinkall marked this pull request as draft October 8, 2023 13:43
@gagb
Copy link
Collaborator

gagb commented Oct 24, 2023

@pcdeadeasy this PR was to address your feedback on a previous PR. Please review it or if its not a big deal close the issue and the PR -- its 2 weeks old now.

#23

@thinkall thinkall closed this Oct 30, 2023
@thinkall thinkall deleted the rename_retrieve branch April 2, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants