-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build for React Native Android - new step/task "Running jetifier" (AndroidX, React-Native 0.60) #887
Comments
I am facing issue with react-native-gesture-handler. Any update on this issue ? |
Hi there, we're taking a look at this issue and working on a solution at the moment! Thanks for your patience! |
Hello everyone, the fix for this issue has been deployed recently. Could you please re-save build configuration and run a new build to validate that everything works for you? |
@max-lobanov, everything works good. Thank you! |
Great! |
Looks like Run Jetify task disapear from appcenter a few days ago |
@a-sane What React Native version are you using? |
@dennispan 0.61.5 |
@a-sane That should work. Could you reach out to support (via the portal)? That'll allow us to collect your app details and look further |
@dennispan I also have the same problem since today. jetify task not running |
@addingama Our team tried couple test applications and couldn't reproduce. Do you mind also reaching out to support for us to take a deeper look? |
We had the same problem since two weeks ago. I repushed the branch under a new name and it's working again. Not great |
@dennispan Two days ago everything was good, but now jetify task not running. React Native v0.62.2 |
@artemkhalygov Please reach out to support so we can take a deeper look. |
Not working for me today either. React Native 0.63.0.
and I setup an |
Everything was working fine but today it just happened. I setup an |
UPDATE: |
Seems that jetifier decided to add some extra messages that might be breaking builds: |
Fix your dependencies - that is take the messages into account by proposing PRs to the few straggling modules or use patch-package to fix them locally - at some point jetifier needs to sunset, so far with one day live it appears react-native-track-player and...no other module people have reported are left as stragglers. Close to the finish line on jetifier it just needs your help to fix the final module(s) your app depends on |
It appears the console.warn's I added are mapped to stderr somehow? That should not happen, and I believe Hope this helps |
Well, today I learned emitting something on console.warn is a breaking change. Honestly shocked about that. I issued [email protected] that is equivalent to 1.6.6, no console.warn deprecation. I am going to re-issue the deprecation notice, but if it's a breaking change okay - it'll go out as 2.0. If AppCenter still breaks at that point at least I was trying semver... |
you are a saint thx! |
@mikehardy I am using 2.0.0 jetifier but have the same problem as author of this issue. Could you help please? |
@Arkan4ik as far as I can tell this has nothing to do with me anymore. If you need jetifier to work still, with no console.warns, use v1.x. If you want the deprecation notice, use 2.x But in my firm opinion, my own software should never be used by anyone anymore. AndroidX conversion is or should be complete and the I'm not personally going to spend any more time on AndroidX transition for that reason. The transition is over |
@mikehardy 1.68 version solved my problem, thank you. I will take a look to get rid of jetifier later |
Describe the solution you'd like
Add new step/task "Running jetifier" in App Center Build services for React Native Android.
React Native 0.60 has been migrated over to AndroidX.
This is a breaking change that makes impossible using App Center Build for React Native Android without additional configuration.
Official React Native blog post about AndroidX breaking change in React Native 0.60 - https://facebook.github.io/react-native/blog/2019/07/03/version-60#androidx-support
react-native run-android
command now runs jetifier automatically:https://github.com/react-native-community/cli/blob/master/packages/platform-android/src/commands/runAndroid/index.ts#L70
This automatic jetifier run in react-native cli makes ambiguous why App Center Build service doesn't work for React Native Android.
Describe alternatives you've considered
Create
appcenter-pre-build.sh
script with following content:Additional context
This is important only when React Native project uses react-native modules that are not migrated to AndroidX yet.
Examples of such modules (2019-08-14):
The text was updated successfully, but these errors were encountered: