Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade test apps to react native 0.59 #558

Merged
merged 17 commits into from
Apr 8, 2019
Merged

Upgrade test apps to react native 0.59 #558

merged 17 commits into from
Apr 8, 2019

Conversation

dtrabo
Copy link
Contributor

@dtrabo dtrabo commented Mar 20, 2019

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Upgraded TestApp, TestAppTypeScript, DemoApp to RN 0.59.0

@dtrabo dtrabo requested a review from roland-chernov March 20, 2019 17:05
dhei
dhei reviewed Mar 22, 2019
View reviewed changes
DemoApp/package.json Outdated Show resolved Hide resolved
@dhei
Copy link
Member

dhei commented Mar 26, 2019

There is an issue of react-navigation with jest framework blocking the upgrade to RN 0.59.x. The error stacktrace from jest looks like this:

TypeError: Cannot read property 'default' of undefined

and full stacktrace can be found at here.

We reported react-navigation/react-navigation#5742 on react-navigation to track this.

@dhei dhei changed the title Upgrade test apps Upgrade test apps to react native 0.59 Mar 26, 2019
@annakocheshkova
Copy link

Applied several fixes from this thread.

@annakocheshkova annakocheshkova marked this pull request as ready for review March 28, 2019 13:28
MatkovIvan
MatkovIvan previously approved these changes Mar 28, 2019
View reviewed changes
@dhei dhei removed the do not merge label Apr 8, 2019
@dhei dhei merged commit 72fc203 into develop Apr 8, 2019
@dhei dhei deleted the v-dmtrab/upgrade-test-apps-to-RN059 branch April 8, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhei dhei dhei approved these changes

@MatkovIvan MatkovIvan MatkovIvan left review comments

@roland-chernov roland-chernov Awaiting requested review from roland-chernov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dtrabo @dhei @annakocheshkova @MatkovIvan