Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test apps to [email protected] to make jest pass #440

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Update test apps to [email protected] to make jest pass #440

merged 2 commits into from
Oct 17, 2018

Conversation

dhei
Copy link
Member

@dhei dhei commented Oct 17, 2018

RN CI is failing on jest (https://msmobilecenter.visualstudio.com/SDK/_build/results?buildId=352503&view=logs) due to an issue with RN v0.57.0 and fixed in RN v0.57.3.

Per the above GitHub thread, we just need to ping react-native to v0.57.3 and upgrade the react-test-renderer dependency to the proper version.

@dhei dhei mentioned this pull request Oct 17, 2018
Merged
@guperrot guperrot merged commit 375aa30 into develop Oct 17, 2018
@guperrot guperrot deleted the dihei/rn-0.57.3 branch October 17, 2018 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guperrot guperrot guperrot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhei @guperrot