From 5f7860fc9cabd4b5d96ac1489614c93fe0e83891 Mon Sep 17 00:00:00 2001 From: v-rakeshsh <155614445+v-rakeshsh@users.noreply.github.com> Date: Mon, 28 Oct 2024 05:19:20 +0530 Subject: [PATCH] CG work item fix for System.Text.JSON package (#1871) Updated System.Text.Json to 8.0.5 to address https://github.com/advisories/GHSA-hh2w-p6rv-4g7w. This will fix CG issue https://dev.azure.com/mseng/1ES/_workitems/edit/2221678/?view=edit Along with this updated its root dependencies to latest. **NOTE: After updating the version, test case was failing in pipeline with below error** **Error Log:** Failed AllDropFilesAreAccountedFor [136 ms] **Error Message:** Assert.IsFalse failed. 1 drop files are missing from "ProductComponent" of WXS: Microsoft.Bcl.TimeProvider.dll **Stack Trace: at MsiFileTests.WxsValidationTests.CompareWxsSectionToDropPath(String repoRoot, String relativeDropPath, String wxsFile, String wxsComponentId, HashSet`1 intentionalExclusions) in D:\a\_work\1\s\src\MsiFileTests\WxsValidationTests.cs:line 48 at MsiFileTests.WxsValidationTests.AllDropFilesAreAccountedFor() in D:\a\_work\1\s\src\MsiFileTests\WxsValidationTests.cs:line 25** Results File: D:\a\_work\_temp\TestResults\cloudtest_d22066dec000000_2024-10-17_06_24_32.trx To fix above, made changes in **Product.wxs** as below **Added below code to fix the error in pipeline:** `` --- .../Extensions.AzureDevOps.csproj | 10 +++++----- src/MSI/Product.wxs | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/AccessibilityInsights.Extensions.AzureDevOps/Extensions.AzureDevOps.csproj b/src/AccessibilityInsights.Extensions.AzureDevOps/Extensions.AzureDevOps.csproj index f89482367..56b82307b 100644 --- a/src/AccessibilityInsights.Extensions.AzureDevOps/Extensions.AzureDevOps.csproj +++ b/src/AccessibilityInsights.Extensions.AzureDevOps/Extensions.AzureDevOps.csproj @@ -24,20 +24,20 @@ - - - + + + - + - + diff --git a/src/MSI/Product.wxs b/src/MSI/Product.wxs index e6fa7ceda..5d284823f 100644 --- a/src/MSI/Product.wxs +++ b/src/MSI/Product.wxs @@ -74,6 +74,7 @@ Licensed under the MIT license. See LICENSE file in the project root for full li +