From 3f957a51dbc377acc2482d82e7c60b6224b0135f Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 11:38:10 +0530 Subject: [PATCH 1/9] initial checkin to disable publish report --- pipeline/build-shared.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index 3d2a884fdc7..693f646ee3e 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -87,6 +87,7 @@ extends: # to be worth the 1min it adds to the build. # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. # reportDirectory: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/lcov-report + enabled: false displayName: publish code coverage timeoutInMinutes: 5 From 010407cd64d362ca0a24bd8e4fcd2db86164db25 Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 11:43:12 +0530 Subject: [PATCH 2/9] initial checkin to disable publish report --- .github/workflows/ci.yml | 1 + pipeline/build-shared.yaml | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dc9256a09a9..c8ef8926ba4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,6 +82,7 @@ jobs: publish-code-coverage: needs: unit-tests # This waits for *all* of the unit-tests jobs runs-on: ubuntu-20.04 + enable: false steps: # This only needs to be present so codecov can use the source tree for some post-processing # This job doesn't require that we install dependencies diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index 693f646ee3e..3d2a884fdc7 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -87,7 +87,6 @@ extends: # to be worth the 1min it adds to the build. # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. # reportDirectory: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/lcov-report - enabled: false displayName: publish code coverage timeoutInMinutes: 5 From 07442df17aae6e170df95bb2a30c834b5c7bab5d Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 11:54:44 +0530 Subject: [PATCH 3/9] initial checkin to disable publish report --- .github/workflows/ci.yml | 1 - pipeline/build-shared.yaml | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c8ef8926ba4..dc9256a09a9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -82,7 +82,6 @@ jobs: publish-code-coverage: needs: unit-tests # This waits for *all* of the unit-tests jobs runs-on: ubuntu-20.04 - enable: false steps: # This only needs to be present so codecov can use the source tree for some post-processing # This job doesn't require that we install dependencies diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index 3d2a884fdc7..bb31bf15b29 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -83,6 +83,7 @@ extends: codeCoverageTool: Cobertura summaryFileLocation: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/cobertura-coverage.xml failIfCoverageEmpty: true + enable: false # We care most about the summary information; adding the detailed files doesn't give enough extra information # to be worth the 1min it adds to the build. # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. From b722cd4c8fa55e4028cab039c48616a115f2df5d Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 12:02:44 +0530 Subject: [PATCH 4/9] initial checkin to disable publish report --- pipeline/build-shared.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index bb31bf15b29..3d2a884fdc7 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -83,7 +83,6 @@ extends: codeCoverageTool: Cobertura summaryFileLocation: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/cobertura-coverage.xml failIfCoverageEmpty: true - enable: false # We care most about the summary information; adding the detailed files doesn't give enough extra information # to be worth the 1min it adds to the build. # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. From 12cd042d22f20ca22a173dc1b0304784d88d451b Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 12:11:33 +0530 Subject: [PATCH 5/9] initial checkin to disable publish report --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dc9256a09a9..603011b63ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -80,6 +80,7 @@ jobs: timeout-minutes: 5 publish-code-coverage: + if: false needs: unit-tests # This waits for *all* of the unit-tests jobs runs-on: ubuntu-20.04 steps: From 2e4e1088c3f8bf21a673abfb14ed078f9a594c1f Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 19:24:55 +0530 Subject: [PATCH 6/9] disable code coverage command in ci --- .github/workflows/ci.yml | 55 ++++++++++++++++++++-------------------- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 603011b63ae..57eb5ef16d6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -79,34 +79,33 @@ jobs: test-results/unit/coverage/cobertura-coverage.xml timeout-minutes: 5 - publish-code-coverage: - if: false - needs: unit-tests # This waits for *all* of the unit-tests jobs - runs-on: ubuntu-20.04 - steps: - # This only needs to be present so codecov can use the source tree for some post-processing - # This job doesn't require that we install dependencies - - uses: actions/checkout@v4.1.7 - timeout-minutes: 2 - - - uses: actions/setup-node@v4 - with: { node-version: "${{ env.NODE_VERSION }}" } - timeout-minutes: 2 - - - uses: actions/download-artifact@v4 - with: - name: unit-tests-1-results - path: unit-tests-1-results - timeout-minutes: 2 - - - uses: actions/download-artifact@v4 - with: - name: unit-tests-2-results - path: unit-tests-2-results - timeout-minutes: 2 - - - run: npx codecov - timeout-minutes: 3 + # publish-code-coverage: + # needs: unit-tests # This waits for *all* of the unit-tests jobs + # runs-on: ubuntu-20.04 + # steps: + # # This only needs to be present so codecov can use the source tree for some post-processing + # # This job doesn't require that we install dependencies + # - uses: actions/checkout@v4.1.7 + # timeout-minutes: 2 + + # - uses: actions/setup-node@v4 + # with: { node-version: "${{ env.NODE_VERSION }}" } + # timeout-minutes: 2 + + # - uses: actions/download-artifact@v4 + # with: + # name: unit-tests-1-results + # path: unit-tests-1-results + # timeout-minutes: 2 + + # - uses: actions/download-artifact@v4 + # with: + # name: unit-tests-2-results + # path: unit-tests-2-results + # timeout-minutes: 2 + + # - run: npx codecov + # timeout-minutes: 3 lints: runs-on: ubuntu-20.04 From ffabfda203b60e98e3f946951e5df1b6815cacee Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Thu, 26 Sep 2024 19:43:36 +0530 Subject: [PATCH 7/9] disable code coverage command in ci --- pipeline/build-shared.yaml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index 3d2a884fdc7..cc31a6acd7e 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -78,21 +78,21 @@ extends: displayName: publish test results timeoutInMinutes: 3 - - task: PublishCodeCoverageResults@1 - inputs: - codeCoverageTool: Cobertura - summaryFileLocation: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/cobertura-coverage.xml - failIfCoverageEmpty: true - # We care most about the summary information; adding the detailed files doesn't give enough extra information - # to be worth the 1min it adds to the build. - # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. - # reportDirectory: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/lcov-report - displayName: publish code coverage - timeoutInMinutes: 5 - - - script: yarn publish-code-coverage -t $(CODECOV_TOKEN) - displayName: Publish code coverage to codecov - timeoutInMinutes: 3 + # - task: PublishCodeCoverageResults@1 + # inputs: + # codeCoverageTool: Cobertura + # summaryFileLocation: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/cobertura-coverage.xml + # failIfCoverageEmpty: true + # # We care most about the summary information; adding the detailed files doesn't give enough extra information + # # to be worth the 1min it adds to the build. + # # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. + # # reportDirectory: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/lcov-report + # displayName: publish code coverage + # timeoutInMinutes: 5 + + # - script: yarn publish-code-coverage -t $(CODECOV_TOKEN) + # displayName: Publish code coverage to codecov + # timeoutInMinutes: 3 - job: 'publish_build_drops' templateContext: From 3f3e92e69a4e53b30d59b88a2138838b4eb4a32e Mon Sep 17 00:00:00 2001 From: Vikash Yadav Date: Thu, 26 Sep 2024 12:09:04 -0400 Subject: [PATCH 8/9] update shared yaml --- pipeline/build-shared.yaml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index cc31a6acd7e..cddb1851327 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -78,17 +78,17 @@ extends: displayName: publish test results timeoutInMinutes: 3 - # - task: PublishCodeCoverageResults@1 - # inputs: - # codeCoverageTool: Cobertura - # summaryFileLocation: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/cobertura-coverage.xml - # failIfCoverageEmpty: true - # # We care most about the summary information; adding the detailed files doesn't give enough extra information - # # to be worth the 1min it adds to the build. - # # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. - # # reportDirectory: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/lcov-report - # displayName: publish code coverage - # timeoutInMinutes: 5 + - task: PublishCodeCoverageResults@1 + inputs: + codeCoverageTool: Cobertura + summaryFileLocation: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/cobertura-coverage.xml + failIfCoverageEmpty: true + # We care most about the summary information; adding the detailed files doesn't give enough extra information + # to be worth the 1min it adds to the build. + # Consider re-enabling this once https://github.com/Microsoft/azure-pipelines-tasks/issues/4945 is resolved. + # reportDirectory: $(System.DefaultWorkingDirectory)/test-results/unit/coverage/lcov-report + displayName: publish code coverage + timeoutInMinutes: 5 # - script: yarn publish-code-coverage -t $(CODECOV_TOKEN) # displayName: Publish code coverage to codecov From 1339c698378ecfc627208223a858ddc7e4105f1e Mon Sep 17 00:00:00 2001 From: Rakesh Shivapooja Date: Fri, 27 Sep 2024 11:26:13 +0530 Subject: [PATCH 9/9] removing commented code in yml files --- .github/workflows/ci.yml | 28 ---------------------------- pipeline/build-shared.yaml | 4 ---- 2 files changed, 32 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 57eb5ef16d6..3306fed18bf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -79,34 +79,6 @@ jobs: test-results/unit/coverage/cobertura-coverage.xml timeout-minutes: 5 - # publish-code-coverage: - # needs: unit-tests # This waits for *all* of the unit-tests jobs - # runs-on: ubuntu-20.04 - # steps: - # # This only needs to be present so codecov can use the source tree for some post-processing - # # This job doesn't require that we install dependencies - # - uses: actions/checkout@v4.1.7 - # timeout-minutes: 2 - - # - uses: actions/setup-node@v4 - # with: { node-version: "${{ env.NODE_VERSION }}" } - # timeout-minutes: 2 - - # - uses: actions/download-artifact@v4 - # with: - # name: unit-tests-1-results - # path: unit-tests-1-results - # timeout-minutes: 2 - - # - uses: actions/download-artifact@v4 - # with: - # name: unit-tests-2-results - # path: unit-tests-2-results - # timeout-minutes: 2 - - # - run: npx codecov - # timeout-minutes: 3 - lints: runs-on: ubuntu-20.04 env: { PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 } diff --git a/pipeline/build-shared.yaml b/pipeline/build-shared.yaml index cddb1851327..9c03734f54f 100644 --- a/pipeline/build-shared.yaml +++ b/pipeline/build-shared.yaml @@ -90,10 +90,6 @@ extends: displayName: publish code coverage timeoutInMinutes: 5 - # - script: yarn publish-code-coverage -t $(CODECOV_TOKEN) - # displayName: Publish code coverage to codecov - # timeoutInMinutes: 3 - - job: 'publish_build_drops' templateContext: outputs: