From bc28c3c61ceace0f7a91ec1972c621a7317c5c87 Mon Sep 17 00:00:00 2001 From: Rohit Tarpara Date: Wed, 19 Jun 2024 14:56:58 +0530 Subject: [PATCH 1/6] Updated axe-core 4.9.1 --- package.json | 2 +- packages/report/package.json | 2 +- packages/ui/package.json | 2 +- .../__snapshots__/settings-drop-down.test.ts.snap | 1 - .../__snapshots__/preview-features.test.ts.snap | 1 - .../__snapshots__/settings-panel.test.ts.snap | 4 ++-- .../__snapshots__/first-time-dialog.test.ts.snap | 1 - .../__snapshots__/hamburger-menu.test.ts.snap | 2 -- .../popup/__snapshots__/launchpad.test.ts.snap | 4 ++-- .../scanner/map-axe-tags-to-guidance-links.test.ts | 10 +++++++++- yarn.lock | 14 +++++++------- 11 files changed, 23 insertions(+), 20 deletions(-) diff --git a/package.json b/package.json index 3c9080a1cdc..9f5db09a5fd 100644 --- a/package.json +++ b/package.json @@ -155,7 +155,7 @@ "@microsoft/applicationinsights-web": "^2.8.15", "@testing-library/user-event": "^14.5.2", "ajv": "^8.12.0", - "axe-core": "4.8.4", + "axe-core": "4.9.1", "classnames": "^2.5.1", "idb-keyval": "^6.2.1", "lodash": "^4.17.21", diff --git a/packages/report/package.json b/packages/report/package.json index 56b8497ad2e..064efff50ee 100644 --- a/packages/report/package.json +++ b/packages/report/package.json @@ -19,7 +19,7 @@ }, "dependencies": { "@fluentui/react": "^8.118.1", - "axe-core": "4.8.4", + "axe-core": "4.9.1", "classnames": "^2.5.1", "lodash": "^4.17.21", "luxon": "^3.4.4", diff --git a/packages/ui/package.json b/packages/ui/package.json index c44dc002fa1..f3c1dd7cf3f 100644 --- a/packages/ui/package.json +++ b/packages/ui/package.json @@ -18,7 +18,7 @@ }, "dependencies": { "@fluentui/react": "^8.96.1", - "axe-core": "4.8.4", + "axe-core": "4.9.1", "classnames": "^2.5.1", "lodash": "^4.17.21", "luxon": "^3.4.4", diff --git a/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap b/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap index 24c24d3428e..a92f4784d69 100644 --- a/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap +++ b/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap @@ -11,7 +11,6 @@ exports[`Settings Dropdown content should match snapshot 1`] = `
- 4.8.4 + 4.9.1 diff --git a/src/tests/unit/tests/scanner/map-axe-tags-to-guidance-links.test.ts b/src/tests/unit/tests/scanner/map-axe-tags-to-guidance-links.test.ts index c3543796a25..52193f945c7 100644 --- a/src/tests/unit/tests/scanner/map-axe-tags-to-guidance-links.test.ts +++ b/src/tests/unit/tests/scanner/map-axe-tags-to-guidance-links.test.ts @@ -17,7 +17,15 @@ describe('mapAxeTagsToGuidanceLinks', () => { expect(mapAxeTagsToGuidanceLinks(defaultIncludedRuleId, tags)).toEqual([]); }); - const wcagAAAtags = ['wcag146', 'wcag223', 'wcag224', 'wcag248', 'wcag249', 'wcag325']; + const wcagAAAtags = [ + 'wcag146', + 'wcag213', + 'wcag223', + 'wcag224', + 'wcag248', + 'wcag249', + 'wcag325', + ]; const irrelevantAxeCoreTags = [ // axe-core specific, not required for our purposes diff --git a/yarn.lock b/yarn.lock index 3b5351a807a..9dc244c2a27 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2793,7 +2793,7 @@ __metadata: resolution: "accessibility-insights-report@workspace:packages/report" dependencies: "@fluentui/react": ^8.118.1 - axe-core: 4.8.4 + axe-core: 4.9.1 classnames: ^2.5.1 lodash: ^4.17.21 luxon: ^3.4.4 @@ -2809,7 +2809,7 @@ __metadata: resolution: "accessibility-insights-ui@workspace:packages/ui" dependencies: "@fluentui/react": ^8.96.1 - axe-core: 4.8.4 + axe-core: 4.9.1 classnames: ^2.5.1 lodash: ^4.17.21 luxon: ^3.4.4 @@ -2850,7 +2850,7 @@ __metadata: "@typescript-eslint/eslint-plugin": ^5.61.0 "@typescript-eslint/parser": ^6.18.1 ajv: ^8.12.0 - axe-core: 4.8.4 + axe-core: 4.9.1 case-sensitive-paths-webpack-plugin: ^2.4.0 classnames: ^2.5.1 codecov: ^3.8.3 @@ -3361,10 +3361,10 @@ __metadata: languageName: node linkType: hard -"axe-core@npm:4.8.4": - version: 4.8.4 - resolution: "axe-core@npm:4.8.4" - checksum: 644da2fec17bcf6f834edaab1baa5a75a9a3ee370c323215c73da6d7e45fac11d01470d92d0a3d5f26695e15c1d9b781733dfbe1fe09d505076c58f09ed74e02 +"axe-core@npm:4.9.1": + version: 4.9.1 + resolution: "axe-core@npm:4.9.1" + checksum: 41d9227871781f96c2952e2a777fca73624959dd0e98864f6d82806a77602f82b4fc490852082a7e524d8cd864e50d8b4d9931819b4a150112981d8c932110c5 languageName: node linkType: hard From 1f9eab661219118ae8c0beaec83594fee57072f2 Mon Sep 17 00:00:00 2001 From: Rohit Tarpara Date: Wed, 19 Jun 2024 15:37:54 +0530 Subject: [PATCH 2/6] Reverted snap files which throw error --- .../tests/common/__snapshots__/settings-drop-down.test.ts.snap | 1 + .../details-view/__snapshots__/preview-features.test.ts.snap | 1 + .../tests/popup/__snapshots__/first-time-dialog.test.ts.snap | 1 + .../tests/popup/__snapshots__/hamburger-menu.test.ts.snap | 2 ++ 4 files changed, 5 insertions(+) diff --git a/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap b/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap index a92f4784d69..24c24d3428e 100644 --- a/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap +++ b/src/tests/end-to-end/tests/common/__snapshots__/settings-drop-down.test.ts.snap @@ -11,6 +11,7 @@ exports[`Settings Dropdown content should match snapshot 1`] = `
    Preview Features Panel should match content in snapshot />