diff --git a/src/DetailsView/components/details-view-command-bar.tsx b/src/DetailsView/components/details-view-command-bar.tsx
index 2d9fe14e8ac..a73659ca89f 100644
--- a/src/DetailsView/components/details-view-command-bar.tsx
+++ b/src/DetailsView/components/details-view-command-bar.tsx
@@ -123,7 +123,6 @@ export class DetailsViewCommandBar extends React.Component<
isInvalidLoadAssessmentDialogOpen: false,
isLoadAssessmentDialogOpen: false,
isReportExportDialogOpen: false,
- isMoveToAssessmentDialogOpen: false,
loadedAssessmentData: {} as VersionedAssessmentData,
startOverDialogState: 'none',
};
diff --git a/src/DetailsView/components/issue-filing-dialog.tsx b/src/DetailsView/components/issue-filing-dialog.tsx
index 643bac8d3c6..891b3b4d79f 100644
--- a/src/DetailsView/components/issue-filing-dialog.tsx
+++ b/src/DetailsView/components/issue-filing-dialog.tsx
@@ -9,7 +9,10 @@ import * as React from 'react';
import { IssueFilingActionMessageCreator } from '../../common/message-creators/issue-filing-action-message-creator';
import { UserConfigMessageCreator } from '../../common/message-creators/user-config-message-creator';
import { CreateIssueDetailsTextData } from '../../common/types/create-issue-details-text-data';
-import { IssueFilingServicePropertiesMap } from '../../common/types/store-data/user-configuration-store';
+import {
+ IssueFilingServiceProperties,
+ IssueFilingServicePropertiesMap,
+} from '../../common/types/store-data/user-configuration-store';
import {
IssueFilingSettingsContainer,
IssueFilingSettingsContainerDeps,
@@ -25,6 +28,7 @@ export interface IssueFilingDialogProps {
isOpen: boolean;
selectedIssueFilingService: IssueFilingService;
selectedIssueData?: CreateIssueDetailsTextData;
+ selectedIssueFilingServiceData: IssueFilingServiceProperties;
issueFilingServicePropertiesMap: IssueFilingServicePropertiesMap;
onClose: (ev?: React.SyntheticEvent) => void;
afterClosed?: () => void;
diff --git a/src/DetailsView/components/save-assessment-button.tsx b/src/DetailsView/components/save-assessment-button.tsx
index 149cdaf4067..c654dea7bb0 100644
--- a/src/DetailsView/components/save-assessment-button.tsx
+++ b/src/DetailsView/components/save-assessment-button.tsx
@@ -74,7 +74,7 @@ export const SaveAssessmentButton = NamedFC
(
>
),
diff --git a/src/common/components/cards/common-instances-section-props.ts b/src/common/components/cards/common-instances-section-props.ts
index 60567f18706..351ed8777ba 100644
--- a/src/common/components/cards/common-instances-section-props.ts
+++ b/src/common/components/cards/common-instances-section-props.ts
@@ -6,6 +6,7 @@ import { ScanMetadata } from 'common/types/store-data/unified-data-interface';
import { NarrowModeStatus } from 'DetailsView/components/narrow-mode-detector';
import { CardsViewModel } from '../../types/store-data/card-view-model';
import { UserConfigurationStoreData } from '../../types/store-data/user-configuration-store';
+import { CardsViewStoreData } from './cards-view-store-data';
import { ResultSectionDeps } from './result-section';
export type CommonInstancesSectionDeps = ResultSectionDeps;
@@ -18,4 +19,5 @@ export type CommonInstancesSectionProps = {
cardSelectionMessageCreator?: CardSelectionMessageCreator;
sectionHeadingLevel: HeadingLevel;
narrowModeStatus?: NarrowModeStatus;
+ cardsViewStoreData?: CardsViewStoreData;
};
diff --git a/src/common/components/visualization-toggle.tsx b/src/common/components/visualization-toggle.tsx
index 0a46c44b364..79826d1b6a7 100644
--- a/src/common/components/visualization-toggle.tsx
+++ b/src/common/components/visualization-toggle.tsx
@@ -31,7 +31,7 @@ export class VisualizationToggle extends React.Component;
}
diff --git a/src/common/configs/unified-result-property-configurations.tsx b/src/common/configs/unified-result-property-configurations.tsx
index 6ae3cb36d13..f69baf7d231 100644
--- a/src/common/configs/unified-result-property-configurations.tsx
+++ b/src/common/configs/unified-result-property-configurations.tsx
@@ -22,6 +22,7 @@ export const AllPropertyTypes = [
'className',
'contentDescription',
'text',
+ 'urls',
'relatedCssSelectors',
] as const;
export type PropertyType = (typeof AllPropertyTypes)[number];
diff --git a/src/injected/analyzers/analyzer.ts b/src/injected/analyzers/analyzer.ts
index 635eb7bd538..bd38fdff693 100644
--- a/src/injected/analyzers/analyzer.ts
+++ b/src/injected/analyzers/analyzer.ts
@@ -31,6 +31,10 @@ export interface ScanUpdatePayload extends ScanBasePayload {
results: TabStopEvent[];
}
+export interface TabStopScanUpdatePayload extends ScanUpdatePayload {
+ tabbedElements: TabStopEvent[];
+}
+
export interface ScanBasePayload extends BaseActionPayload {
testType: VisualizationType;
key: string;
diff --git a/src/injected/analyzers/tab-stops-analyzer.ts b/src/injected/analyzers/tab-stops-analyzer.ts
index 8f561102f37..8f73133b0c7 100644
--- a/src/injected/analyzers/tab-stops-analyzer.ts
+++ b/src/injected/analyzers/tab-stops-analyzer.ts
@@ -9,7 +9,7 @@ import { TabStopsDoneAnalyzingTracker } from 'injected/analyzers/tab-stops-done-
import { TabStopsRequirementResultProcessor } from 'injected/analyzers/tab-stops-requirement-result-processor';
import { ScanIncompleteWarningDetector } from 'injected/scan-incomplete-warning-detector';
import { debounce, DebouncedFunc } from 'lodash';
-import { FocusAnalyzerConfiguration, ScanBasePayload, ScanUpdatePayload } from './analyzer';
+import { FocusAnalyzerConfiguration, ScanBasePayload, TabStopScanUpdatePayload } from './analyzer';
export interface ProgressResult {
result: T;
@@ -55,7 +55,7 @@ export class TabStopsAnalyzer extends BaseAnalyzer {
const results = this.pendingTabbedElements;
this.pendingTabbedElements = [];
- const payload: ScanUpdatePayload = {
+ const payload: TabStopScanUpdatePayload = {
key: this.config.key,
testType: this.config.testType,
tabbedElements: results,
diff --git a/src/packages/accessibility-insights-ui/ui-factory.tsx b/src/packages/accessibility-insights-ui/ui-factory.tsx
index 90d168234c6..f2b3a697ef0 100644
--- a/src/packages/accessibility-insights-ui/ui-factory.tsx
+++ b/src/packages/accessibility-insights-ui/ui-factory.tsx
@@ -32,9 +32,6 @@ export const contentViewFactory = ({ applicationTitle, getNarrowModeThresholds }
textContent: {
applicationTitle,
},
- storeActionMessageCreator: {
- getAllStates: nullCreator,
- },
storesHub: nullStoresHub,
getNarrowModeThresholds,
};
diff --git a/src/report-export/services/code-pen-report-export-service.tsx b/src/report-export/services/code-pen-report-export-service.tsx
index c96ce2d238d..30db8f99604 100644
--- a/src/report-export/services/code-pen-report-export-service.tsx
+++ b/src/report-export/services/code-pen-report-export-service.tsx
@@ -31,7 +31,6 @@ class CodePenExportForm extends React.Component {
action="https://codepen.io/pen/define"
method="POST"
target="_blank"
- rel="noopener"
style={{ visibility: 'hidden' }}
>
(
header: ,
content: ,
headingLevel: props.headingLevel,
- deps: null,
testKey,
onExpandToggle: (event: React.MouseEvent) => {
cardSelectionMessageCreator?.toggleRuleExpandCollapse(containerId, event);
diff --git a/src/reports/components/report-sections/report-collapsible-container.tsx b/src/reports/components/report-sections/report-collapsible-container.tsx
index 5fef2860a18..288a0016460 100644
--- a/src/reports/components/report-sections/report-collapsible-container.tsx
+++ b/src/reports/components/report-sections/report-collapsible-container.tsx
@@ -14,6 +14,7 @@ export interface ReportCollapsibleContainerProps {
containerClassName?: string;
buttonAriaLabel?: string;
testKey?: string;
+ onExpandToggle?: (event: React.MouseEvent) => void;
}
const ReportCollapsibleContainer = NamedFC(
diff --git a/src/tests/unit/tests/DetailsView/components/__snapshots__/choice-group-pass-fail.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/__snapshots__/choice-group-pass-fail.test.tsx.snap
index 00497406190..3e2b52e7c9c 100644
--- a/src/tests/unit/tests/DetailsView/components/__snapshots__/choice-group-pass-fail.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/__snapshots__/choice-group-pass-fail.test.tsx.snap
@@ -6,7 +6,6 @@ exports[`ChoiceGroupPassFail render 1`] = `
class="choiceGroupContainer"
>
{
getSettingsFromStoreData: getSettingsFromStoreDataMock.object,
key: serviceKey,
} as IssueFilingService;
+ const selectedIssueFilingServiceData: IssueFilingServiceProperties = {
+ repository: 'none',
+ };
props = {
deps,
isOpen: true,
onClose: onCloseMock.object,
selectedIssueFilingService: issueFilingServiceStub,
selectedIssueData: selectedIssueDataStub,
+ selectedIssueFilingServiceData,
issueFilingServicePropertiesMap: issueFilingServicePropertiesMapStub,
afterClosed: () => null,
};
diff --git a/src/tests/unit/tests/DetailsView/components/tab-stops/__snapshots__/tab-stops-choice-group.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/tab-stops/__snapshots__/tab-stops-choice-group.test.tsx.snap
index 65d359bd245..ffa96752b29 100644
--- a/src/tests/unit/tests/DetailsView/components/tab-stops/__snapshots__/tab-stops-choice-group.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/tab-stops/__snapshots__/tab-stops-choice-group.test.tsx.snap
@@ -7,7 +7,6 @@ exports[`TabStopsChoiceGroup render with fail status 1`] = `
>
,
"deps": {
"tabStopRequirementActionMessageCreator": [typemoq mock object],
diff --git a/src/tests/unit/tests/packages/accessibility-insights-ui/__snapshots__/ui-factory.test.tsx.snap b/src/tests/unit/tests/packages/accessibility-insights-ui/__snapshots__/ui-factory.test.tsx.snap
index 176e29aa482..ff02806c500 100644
--- a/src/tests/unit/tests/packages/accessibility-insights-ui/__snapshots__/ui-factory.test.tsx.snap
+++ b/src/tests/unit/tests/packages/accessibility-insights-ui/__snapshots__/ui-factory.test.tsx.snap
@@ -15,9 +15,6 @@ exports[`UIFactory exports ContentView: Content props 1`] = `
"children": "CONTENTS",
"deps": {
"getNarrowModeThresholds": [Function],
- "storeActionMessageCreator": {
- "getAllStates": [Function],
- },
"storesHub": {
"addChangedListenerToAllStores": [Function],
"getAllStoreData": [Function],
diff --git a/src/tests/unit/tests/report-export/__snapshots__/code-pen-report-export-service.test.tsx.snap b/src/tests/unit/tests/report-export/__snapshots__/code-pen-report-export-service.test.tsx.snap
index 3f890beb186..e1cc94b89d8 100644
--- a/src/tests/unit/tests/report-export/__snapshots__/code-pen-report-export-service.test.tsx.snap
+++ b/src/tests/unit/tests/report-export/__snapshots__/code-pen-report-export-service.test.tsx.snap
@@ -5,7 +5,6 @@ exports[`CodePenReportExportService exportForm renders 1`] = `