From db5e35d1f8b30383274c9d02db8b3851bb1aacd6 Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Mon, 1 Apr 2024 12:51:20 +0530
Subject: [PATCH 1/9] TypeScript Changes cleanup 2.0

---
 .../components/adhoc-issues-test-view.tsx     |  1 +
 .../components/adhoc-tab-stops-test-view.tsx  |  1 -
 .../left-nav/details-view-left-nav.tsx        |  6 +---
 .../components/report-export-component.tsx    |  3 +-
 .../accessible-names-formatter.ts             |  2 --
 src/popup/components/launch-panel-header.tsx  |  1 -
 .../launch-panel-header-click-handler.ts      |  1 -
 src/reports/components/fast-pass-report.tsx   |  6 +---
 .../collapsible-url-result-section.tsx        |  1 -
 .../report-export-component.test.tsx.snap     |  5 ---
 .../details-view-left-nav.test.tsx.snap       |  2 --
 .../analyzer-configuration-factory.test.ts    |  1 -
 .../launch-panel-header.test.tsx.snap         | 36 -------------------
 .../components/launch-panel-header.test.tsx   |  3 --
 .../launch-panel-header-click-handler.test.ts |  1 -
 ...llapsible-url-result-section.test.tsx.snap |  6 +---
 .../summary-report-html-generator.test.tsx    |  1 -
 17 files changed, 5 insertions(+), 72 deletions(-)

diff --git a/src/DetailsView/components/adhoc-issues-test-view.tsx b/src/DetailsView/components/adhoc-issues-test-view.tsx
index a59a4e7f59c..baa9aebaa03 100644
--- a/src/DetailsView/components/adhoc-issues-test-view.tsx
+++ b/src/DetailsView/components/adhoc-issues-test-view.tsx
@@ -43,6 +43,7 @@ export type AdhocIssuesTestViewProps = {
     instancesSection: ReactFCWithDisplayName<CommonInstancesSectionProps>;
     narrowModeStatus: NarrowModeStatus;
     selectedVisualizationType: VisualizationType;
+    includeStepsText?: boolean;
 };
 
 export const AdhocIssuesTestView = NamedFC<AdhocIssuesTestViewProps>(
diff --git a/src/DetailsView/components/adhoc-tab-stops-test-view.tsx b/src/DetailsView/components/adhoc-tab-stops-test-view.tsx
index 550808c8d05..61fff26c3de 100644
--- a/src/DetailsView/components/adhoc-tab-stops-test-view.tsx
+++ b/src/DetailsView/components/adhoc-tab-stops-test-view.tsx
@@ -196,7 +196,6 @@ export const AdhocTabStopsTestView = NamedFC<AdhocTabStopsTestViewProps>(
                     <TabStopsFailedInstancePanel
                         deps={props.deps}
                         failureInstanceState={props.tabStopsViewStoreData.failureInstanceState}
-                        requirementState={requirementState}
                     />
 
                     <FocusComponent deps={props.deps} tabbingEnabled={scanData.enabled} />
diff --git a/src/DetailsView/components/left-nav/details-view-left-nav.tsx b/src/DetailsView/components/left-nav/details-view-left-nav.tsx
index eb9e86109a8..9a4f8a09431 100644
--- a/src/DetailsView/components/left-nav/details-view-left-nav.tsx
+++ b/src/DetailsView/components/left-nav/details-view-left-nav.tsx
@@ -67,11 +67,7 @@ export const DetailsViewLeftNav = NamedFC<DetailsViewLeftNavProps>('DetailsViewL
 
     const leftNav: JSX.Element = (
         <div className={`${styles.leftNav} main-nav`}>
-            <Switcher
-                deps={props.deps}
-                featureFlagStoreData={featureFlagStoreData}
-                pivotKey={props.selectedPivot}
-            />
+            <Switcher deps={props.deps} pivotKey={props.selectedPivot} />
             <switcherNavConfiguration.LeftNav
                 deps={deps}
                 assessmentsProvider={filteredProvider}
diff --git a/src/DetailsView/components/report-export-component.tsx b/src/DetailsView/components/report-export-component.tsx
index a5e709140a3..d50fc710baf 100644
--- a/src/DetailsView/components/report-export-component.tsx
+++ b/src/DetailsView/components/report-export-component.tsx
@@ -103,11 +103,10 @@ export class ReportExportComponent extends React.Component<
     };
 
     public render(): JSX.Element {
-        const { deps, reportExportFormat, isOpen, featureFlagStoreData } = this.props;
+        const { reportExportFormat, isOpen, featureFlagStoreData } = this.props;
 
         return (
             <ExportDialog
-                deps={deps}
                 isOpen={isOpen}
                 htmlFileName={this.state.htmlExportName}
                 jsonFileName={this.state.jsonExportName}
diff --git a/src/injected/visualization/accessible-names-formatter.ts b/src/injected/visualization/accessible-names-formatter.ts
index 040b8f48b1b..4335e5bc5fb 100644
--- a/src/injected/visualization/accessible-names-formatter.ts
+++ b/src/injected/visualization/accessible-names-formatter.ts
@@ -40,11 +40,9 @@ export class AccessibleNamesFormatter implements Formatter {
                 text: formattedAccessibleName,
                 fontWeight: '400',
                 fontSize: '10px',
-                outline: '3px dashed',
             },
             outlineColor: AccessibleNamesFormatter.style.outlineColor,
             outlineStyle: 'dashed',
-            outlineWidth: '3px',
             showVisualization: true,
         };
         return config;
diff --git a/src/popup/components/launch-panel-header.tsx b/src/popup/components/launch-panel-header.tsx
index 3be5c967d87..b7d1dde5216 100644
--- a/src/popup/components/launch-panel-header.tsx
+++ b/src/popup/components/launch-panel-header.tsx
@@ -71,7 +71,6 @@ export class LaunchPanelHeader extends React.Component<
                     deps={this.props.deps}
                     popupWindow={this.props.popupWindow}
                     header={this}
-                    featureFlagData={featureFlags}
                 />
             </>
         );
diff --git a/src/popup/handlers/launch-panel-header-click-handler.ts b/src/popup/handlers/launch-panel-header-click-handler.ts
index cb94a48afa5..493e9440f36 100644
--- a/src/popup/handlers/launch-panel-header-click-handler.ts
+++ b/src/popup/handlers/launch-panel-header-click-handler.ts
@@ -26,7 +26,6 @@ export class LaunchPanelHeaderClickHandler {
     public onOpenContextualMenu(header: LaunchPanelHeader, event: React.MouseEvent<any>): void {
         header.setState({
             target: event.currentTarget,
-            isContextMenuVisible: true,
         });
     }
 
diff --git a/src/reports/components/fast-pass-report.tsx b/src/reports/components/fast-pass-report.tsx
index b9215c913b3..1ef85a300a7 100644
--- a/src/reports/components/fast-pass-report.tsx
+++ b/src/reports/components/fast-pass-report.tsx
@@ -50,10 +50,7 @@ export const FastPassReport = NamedFC<FastPassReportProps>('FastPassReport', pro
             <ContentContainer>
                 <FastPassTitleSection />
                 <DetailsSection {...props} />
-                <FastPassReportSummary
-                    {...props}
-                    featureFlagStoreData={props.deps.featureFlagStoreData}
-                />
+                <FastPassReportSummary {...props} />
                 <ResultsContainer {...props}>
                     <FastPassResultsTitleSection title="Automated checks" />
                     <FastPassReportAutomatedChecksResults {...props} />
@@ -66,7 +63,6 @@ export const FastPassReport = NamedFC<FastPassReportProps>('FastPassReport', pro
                             tabStopsTestViewController: undefined,
                             ...props.deps,
                         }}
-                        featureFlagStoreData={props.deps.featureFlagStoreData}
                         tabStopRequirementState={props.results.tabStops}
                         alwaysRenderSection={true}
                     />
diff --git a/src/reports/components/report-sections/collapsible-url-result-section.tsx b/src/reports/components/report-sections/collapsible-url-result-section.tsx
index d6e15c0df81..99416c2e26d 100644
--- a/src/reports/components/report-sections/collapsible-url-result-section.tsx
+++ b/src/reports/components/report-sections/collapsible-url-result-section.tsx
@@ -28,7 +28,6 @@ export const CollapsibleUrlResultSection = NamedFC<CollapsibleUrlResultSectionPr
             header: <ResultSectionTitle {...props} titleSize="heading" />,
             content,
             headingLevel: 3,
-            deps: null,
         });
 
         return <div className={styles.urlResultSection}>{CollapsibleContent}</div>;
diff --git a/src/tests/unit/tests/DetailsView/components/__snapshots__/report-export-component.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/__snapshots__/report-export-component.test.tsx.snap
index 3c07f6210b2..dd90e1cd440 100644
--- a/src/tests/unit/tests/DetailsView/components/__snapshots__/report-export-component.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/__snapshots__/report-export-component.test.tsx.snap
@@ -3,7 +3,6 @@
 exports[`ReportExportComponent clicking export on the dialog triggers generateExports, generates json and html with the current exportDescription 1`] = `
 <DocumentFragment>
   <mock-exportdialog
-    deps="[object Object]"
     description="test content with special characters: <> $ " \` '"
     featureflagstoredata="[object Object]"
     htmlexportdata="test html"
@@ -22,7 +21,6 @@ exports[`ReportExportComponent clicking export on the dialog triggers generateEx
 exports[`ReportExportComponent edit text field: test content with special characters: <> $ " \` ' 1`] = `
 <DocumentFragment>
   <mock-exportdialog
-    deps="[object Object]"
     description="test content with special characters: <> $ " \` '"
     featureflagstoredata="[object Object]"
     htmlexportdata=""
@@ -41,7 +39,6 @@ exports[`ReportExportComponent edit text field: test content with special charac
 exports[`ReportExportComponent on dialog opened 1`] = `
 <DocumentFragment>
   <mock-exportdialog
-    deps="[object Object]"
     description="export description"
     featureflagstoredata="[object Object]"
     htmlexportdata=""
@@ -59,7 +56,6 @@ exports[`ReportExportComponent on dialog opened 1`] = `
 exports[`ReportExportComponent render with dialog closed 1`] = `
 <DocumentFragment>
   <mock-exportdialog
-    deps="[object Object]"
     description=""
     featureflagstoredata="[object Object]"
     htmlexportdata=""
@@ -78,7 +74,6 @@ exports[`ReportExportComponent render with dialog closed 1`] = `
 exports[`ReportExportComponent render with dialog open 1`] = `
 <DocumentFragment>
   <mock-exportdialog
-    deps="[object Object]"
     description=""
     featureflagstoredata="[object Object]"
     htmlexportdata=""
diff --git a/src/tests/unit/tests/DetailsView/components/left-nav/__snapshots__/details-view-left-nav.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/left-nav/__snapshots__/details-view-left-nav.test.tsx.snap
index 42652d51176..253340143b2 100644
--- a/src/tests/unit/tests/DetailsView/components/left-nav/__snapshots__/details-view-left-nav.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/left-nav/__snapshots__/details-view-left-nav.test.tsx.snap
@@ -7,7 +7,6 @@ exports[`DetailsViewLeftNav should render from switcher nav 1`] = `
   >
     <mock-switcher
       deps="[object Object]"
-      featureflagstoredata="[object Object]"
     />
     <mock-assessmentleftnav
       assessmentsdata="[object Object]"
@@ -44,7 +43,6 @@ exports[`DetailsViewLeftNav should render from switcher nav: Switcher props 1`]
     "assessmentsProviderWithFeaturesEnabled": [Function],
     "getProvider": [Function],
   },
-  "featureFlagStoreData": {},
   "pivotKey": undefined,
 }
 `;
diff --git a/src/tests/unit/tests/assessments/common/analyzer-configuration-factory.test.ts b/src/tests/unit/tests/assessments/common/analyzer-configuration-factory.test.ts
index fdc704b18b4..e512442299b 100644
--- a/src/tests/unit/tests/assessments/common/analyzer-configuration-factory.test.ts
+++ b/src/tests/unit/tests/assessments/common/analyzer-configuration-factory.test.ts
@@ -11,7 +11,6 @@ import { ScannerUtils } from '../../../../../injected/scanner-utils';
 
 const baseConfig: Readonly<Partial<RuleAnalyzerConfiguration>> = {
     key: 'test-key',
-    testName: 'test-name',
     rules: ['rule-1', 'rule-2'],
     testType: -1 as VisualizationType,
 };
diff --git a/src/tests/unit/tests/popup/components/__snapshots__/launch-panel-header.test.tsx.snap b/src/tests/unit/tests/popup/components/__snapshots__/launch-panel-header.test.tsx.snap
index 0b737623c4e..14ac58546c8 100644
--- a/src/tests/unit/tests/popup/components/__snapshots__/launch-panel-header.test.tsx.snap
+++ b/src/tests/unit/tests/popup/components/__snapshots__/launch-panel-header.test.tsx.snap
@@ -17,7 +17,6 @@ exports[`LaunchPanelHeaderTest renders 1`] = `
     />
     <mock-hamburgermenubutton
       deps="[object Object]"
-      featureflagdata="[object Object]"
       header="[object Object]"
       popupwindow="[object Object]"
     />
@@ -58,7 +57,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
     "launchPanelHeaderClickHandler": {},
     "popupActionMessageCreator": {},
   },
-  "featureFlagData": {},
   "header": LaunchPanelHeader {
     "_reactInternalFiber": FiberNode {
       "_debugHookTypes": null,
@@ -412,7 +410,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                       "launchPanelHeaderClickHandler": {},
                       "popupActionMessageCreator": {},
                     },
-                    "featureFlagData": {},
                     "header": [Circular],
                     "popupWindow": {},
                   },
@@ -426,7 +423,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                       "launchPanelHeaderClickHandler": {},
                       "popupActionMessageCreator": {},
                     },
-                    "featureFlagData": {},
                     "header": [Circular],
                     "popupWindow": {},
                   },
@@ -436,7 +432,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                   "sibling": null,
                   "stateNode": <mock-hamburgermenubutton
                     deps="[object Object]"
-                    featureflagdata="[object Object]"
                     header="[object Object]"
                     popupwindow="[object Object]"
                   />,
@@ -466,7 +461,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                             "popupActionMessageCreator": {},
                           }
                         }
-                        featureFlagData={{}}
                         header={[Circular]}
                         popupWindow={{}}
                       />,
@@ -508,7 +502,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                             "popupActionMessageCreator": {},
                           }
                         }
-                        featureFlagData={{}}
                         header={[Circular]}
                         popupWindow={{}}
                       />,
@@ -682,7 +675,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                     "popupActionMessageCreator": {},
                   }
                 }
-                featureFlagData={{}}
                 header={[Circular]}
                 popupWindow={{}}
               />
@@ -727,7 +719,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                     "popupActionMessageCreator": {},
                   }
                 }
-                featureFlagData={{}}
                 header={[Circular]}
                 popupWindow={{}}
               />
@@ -754,7 +745,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
             />
             <mock-hamburgermenubutton
               deps="[object Object]"
-              featureflagdata="[object Object]"
               header="[object Object]"
               popupwindow="[object Object]"
             />
@@ -804,7 +794,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                         "popupActionMessageCreator": {},
                       }
                     }
-                    featureFlagData={{}}
                     header={[Circular]}
                     popupWindow={{}}
                   />
@@ -855,7 +844,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                         "popupActionMessageCreator": {},
                       }
                     }
-                    featureFlagData={{}}
                     header={[Circular]}
                     popupWindow={{}}
                   />
@@ -903,7 +891,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                   "popupActionMessageCreator": {},
                 }
               }
-              featureFlagData={{}}
               header={[Circular]}
               popupWindow={{}}
             />
@@ -948,7 +935,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                   "popupActionMessageCreator": {},
                 }
               }
-              featureFlagData={{}}
               header={[Circular]}
               popupWindow={{}}
             />
@@ -1000,7 +986,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                         "popupActionMessageCreator": {},
                       }
                     }
-                    featureFlagData={{}}
                     header={[Circular]}
                     popupWindow={{}}
                   />
@@ -1051,7 +1036,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                         "popupActionMessageCreator": {},
                       }
                     }
-                    featureFlagData={{}}
                     header={[Circular]}
                     popupWindow={{}}
                   />
@@ -1077,11 +1061,8 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
           "launchPanelHeaderClickHandler": {},
           "popupActionMessageCreator": {},
         },
-        "dropdownClickHandler": {},
         "featureFlags": {},
         "openAdhocToolsPanel": [Function],
-        "openFeedbackDialog": {},
-        "openGettingStartedDialog": {},
         "popupWindow": {},
         "subtitle": "test subtitle",
         "title": "test title",
@@ -1095,11 +1076,8 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
           "launchPanelHeaderClickHandler": {},
           "popupActionMessageCreator": {},
         },
-        "dropdownClickHandler": {},
         "featureFlags": {},
         "openAdhocToolsPanel": [Function],
-        "openFeedbackDialog": {},
-        "openGettingStartedDialog": {},
         "popupWindow": {},
         "subtitle": "test subtitle",
         "title": "test title",
@@ -1163,7 +1141,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                 />
                 <mock-hamburgermenubutton
                   deps="[object Object]"
-                  featureflagdata="[object Object]"
                   header="[object Object]"
                   popupwindow="[object Object]"
                 />
@@ -1206,11 +1183,8 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                       "popupActionMessageCreator": {},
                     }
                   }
-                  dropdownClickHandler={{}}
                   featureFlags={{}}
                   openAdhocToolsPanel={[Function]}
-                  openFeedbackDialog={{}}
-                  openGettingStartedDialog={{}}
                   popupWindow={{}}
                   subtitle="test subtitle"
                   title="test title"
@@ -1247,11 +1221,8 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                 "popupActionMessageCreator": {},
               }
             }
-            dropdownClickHandler={{}}
             featureFlags={{}}
             openAdhocToolsPanel={[Function]}
-            openFeedbackDialog={{}}
-            openGettingStartedDialog={{}}
             popupWindow={{}}
             subtitle="test subtitle"
             title="test title"
@@ -1284,7 +1255,6 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
               />
               <mock-hamburgermenubutton
                 deps="[object Object]"
-                featureflagdata="[object Object]"
                 header="[object Object]"
                 popupwindow="[object Object]"
               />
@@ -1324,11 +1294,8 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
                   "popupActionMessageCreator": {},
                 }
               }
-              dropdownClickHandler={{}}
               featureFlags={{}}
               openAdhocToolsPanel={[Function]}
-              openFeedbackDialog={{}}
-              openGettingStartedDialog={{}}
               popupWindow={{}}
               subtitle="test subtitle"
               title="test title"
@@ -1363,11 +1330,8 @@ exports[`LaunchPanelHeaderTest renders: HamburgerMenuButton props 1`] = `
         "launchPanelHeaderClickHandler": {},
         "popupActionMessageCreator": {},
       },
-      "dropdownClickHandler": {},
       "featureFlags": {},
       "openAdhocToolsPanel": [Function],
-      "openFeedbackDialog": {},
-      "openGettingStartedDialog": {},
       "popupWindow": {},
       "subtitle": "test subtitle",
       "title": "test title",
diff --git a/src/tests/unit/tests/popup/components/launch-panel-header.test.tsx b/src/tests/unit/tests/popup/components/launch-panel-header.test.tsx
index bcc0756740f..8bf07333445 100644
--- a/src/tests/unit/tests/popup/components/launch-panel-header.test.tsx
+++ b/src/tests/unit/tests/popup/components/launch-panel-header.test.tsx
@@ -45,12 +45,9 @@ describe('LaunchPanelHeaderTest', () => {
             deps,
             title: 'test title',
             subtitle: 'test subtitle',
-            openGettingStartedDialog: {} as any,
-            openFeedbackDialog: {} as any,
             popupWindow: {} as Window,
             featureFlags: {} as FeatureFlagStoreData,
             openAdhocToolsPanel: () => {},
-            dropdownClickHandler: {} as DropdownClickHandler,
         };
     });
 
diff --git a/src/tests/unit/tests/popup/handlers/launch-panel-header-click-handler.test.ts b/src/tests/unit/tests/popup/handlers/launch-panel-header-click-handler.test.ts
index ec744185ec0..e15a999667f 100644
--- a/src/tests/unit/tests/popup/handlers/launch-panel-header-click-handler.test.ts
+++ b/src/tests/unit/tests/popup/handlers/launch-panel-header-click-handler.test.ts
@@ -57,7 +57,6 @@ describe('FeedbackMenuClickHandlerTest', () => {
         const setStateMock = Mock.ofInstance((state: any) => {});
         const stateStub = {
             target: 'currentTarget',
-            isContextMenuVisible: true,
         };
         const eventStub = {
             currentTarget: 'currentTarget',
diff --git a/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap b/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap
index 21ce02e9f1e..e15110bc76b 100644
--- a/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap
+++ b/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap
@@ -4,10 +4,6 @@ exports[`CollapsibleUrlResultSection renders 1`] = `
 <DocumentFragment>
   <div
     class="urlResultSection"
-  >
-    <div>
-      Collapsible component
-    </div>
-  </div>
+  />
 </DocumentFragment>
 `;
diff --git a/src/tests/unit/tests/reports/summary-report-html-generator.test.tsx b/src/tests/unit/tests/reports/summary-report-html-generator.test.tsx
index 50b27c7b801..ec239261a17 100644
--- a/src/tests/unit/tests/reports/summary-report-html-generator.test.tsx
+++ b/src/tests/unit/tests/reports/summary-report-html-generator.test.tsx
@@ -63,7 +63,6 @@ describe('ReportHtmlGenerator', () => {
         };
 
         const results: SummaryScanResults = {
-            deps,
             failed: [
                 {
                     url: `${baseUrl}/failed`,

From 0ffd04b1e62539e80e965621be1c938791e28cc2 Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Tue, 2 Apr 2024 11:17:13 +0530
Subject: [PATCH 2/9] Updated Snapshot for details-view-command-bar file

---
 .../details-view-command-bar.test.tsx.snap      | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/src/tests/unit/tests/DetailsView/components/__snapshots__/details-view-command-bar.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/__snapshots__/details-view-command-bar.test.tsx.snap
index b89f72bce62..6bab4280c53 100644
--- a/src/tests/unit/tests/DetailsView/components/__snapshots__/details-view-command-bar.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/__snapshots__/details-view-command-bar.test.tsx.snap
@@ -88,7 +88,6 @@ exports[`DetailsViewCommandBar renders invalid load assessment dialog: invalid l
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -244,7 +243,6 @@ exports[`DetailsViewCommandBar renders invalid load assessment dialog: invalid l
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -400,7 +398,6 @@ exports[`DetailsViewCommandBar renders load assessment dialog: load assessment d
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -556,7 +553,6 @@ exports[`DetailsViewCommandBar renders load assessment dialog: load assessment d
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -685,7 +681,6 @@ exports[`DetailsViewCommandBar renders report export dialog: export dialog hidde
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -814,7 +809,6 @@ exports[`DetailsViewCommandBar renders report export dialog: export dialog open
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       featureflagstoredata="[object Object]"
       htmlexportdata=""
       htmlfilename="Assessment_20240307_commandbartesttabtit.html"
@@ -979,7 +973,6 @@ exports[`DetailsViewCommandBar renders start assessment over dialog: start asses
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1142,7 +1135,6 @@ exports[`DetailsViewCommandBar renders start assessment over dialog: start asses
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1308,7 +1300,6 @@ exports[`DetailsViewCommandBar renders start test over dialog: start test over d
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1471,7 +1462,6 @@ exports[`DetailsViewCommandBar renders start test over dialog: start test over d
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1603,7 +1593,6 @@ exports[`DetailsViewCommandBar renders transfer to assessment dialog: transfer t
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1735,7 +1724,6 @@ exports[`DetailsViewCommandBar renders transfer to assessment dialog: transfer t
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1834,7 +1822,6 @@ exports[`DetailsViewCommandBar renders with buttons collapsed into a menu 1`] =
     </div>
     <mock-commandbarbuttonsmenu />
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -1975,7 +1962,6 @@ exports[`DetailsViewCommandBar renders with export button and start over 1`] = `
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -2084,7 +2070,6 @@ exports[`DetailsViewCommandBar renders with export button, without start over 1`
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -2192,7 +2177,6 @@ exports[`DetailsViewCommandBar renders without export button and without start o
       </div>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""
@@ -2321,7 +2305,6 @@ exports[`DetailsViewCommandBar renders without export button, with start over 1`
       </button>
     </div>
     <mock-exportdialog
-      deps="[object Object]"
       description=""
       featureflagstoredata="[object Object]"
       htmlexportdata=""

From ce1d17eacea28cce8a6786f04de886e9e3830064 Mon Sep 17 00:00:00 2001
From: Prachi Naigaonkar <v-prachin@microsoft.com>
Date: Fri, 5 Apr 2024 19:05:10 +0530
Subject: [PATCH 3/9] Worked on PR review comments

---
 src/DetailsView/components/adhoc-issues-test-view.tsx      | 1 -
 src/DetailsView/components/assessment-issues-test-view.tsx | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/DetailsView/components/adhoc-issues-test-view.tsx b/src/DetailsView/components/adhoc-issues-test-view.tsx
index baa9aebaa03..a59a4e7f59c 100644
--- a/src/DetailsView/components/adhoc-issues-test-view.tsx
+++ b/src/DetailsView/components/adhoc-issues-test-view.tsx
@@ -43,7 +43,6 @@ export type AdhocIssuesTestViewProps = {
     instancesSection: ReactFCWithDisplayName<CommonInstancesSectionProps>;
     narrowModeStatus: NarrowModeStatus;
     selectedVisualizationType: VisualizationType;
-    includeStepsText?: boolean;
 };
 
 export const AdhocIssuesTestView = NamedFC<AdhocIssuesTestViewProps>(
diff --git a/src/DetailsView/components/assessment-issues-test-view.tsx b/src/DetailsView/components/assessment-issues-test-view.tsx
index 54a1f1b5472..fc80f4799bf 100644
--- a/src/DetailsView/components/assessment-issues-test-view.tsx
+++ b/src/DetailsView/components/assessment-issues-test-view.tsx
@@ -35,6 +35,7 @@ export type AssessmentIssuesTestViewDeps = {
 export type AssessmentIssuesTestViewProps = {
     deps: AssessmentIssuesTestViewDeps;
     assessmentStoreData: AssessmentStoreData;
+    includeStepsText?: boolean;
 } & Omit<AdhocIssuesTestViewProps, 'deps'>;
 
 export class AssessmentIssuesTestView extends React.Component<AssessmentIssuesTestViewProps> {

From 67e15c38cd7121510d5de2fd361fb3522a950cfc Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Mon, 8 Apr 2024 19:42:49 +0530
Subject: [PATCH 4/9] Updated the testcase for deps property

---
 .../collapsible-url-result-section.test.tsx.snap            | 6 +++++-
 .../report-sections/collapsible-url-result-section.test.tsx | 2 +-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap b/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap
index e15110bc76b..21ce02e9f1e 100644
--- a/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap
+++ b/src/tests/unit/tests/reports/components/report-sections/__snapshots__/collapsible-url-result-section.test.tsx.snap
@@ -4,6 +4,10 @@ exports[`CollapsibleUrlResultSection renders 1`] = `
 <DocumentFragment>
   <div
     class="urlResultSection"
-  />
+  >
+    <div>
+      Collapsible component
+    </div>
+  </div>
 </DocumentFragment>
 `;
diff --git a/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx b/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
index 9a59d5cc9fb..cb387c7d328 100644
--- a/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
+++ b/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
@@ -25,7 +25,6 @@ describe('CollapsibleUrlResultSection', () => {
         const expectedCollapsibleControlProps: Partial<CollapsibleComponentCardsProps> = {
             id: containerId,
             headingLevel: 3,
-            deps: null,
         };
 
         collapsibleControlMock
@@ -34,5 +33,6 @@ describe('CollapsibleUrlResultSection', () => {
 
         const wrapper = render(<CollapsibleUrlResultSection {...props} />);
         expect(wrapper.asFragment()).toMatchSnapshot();
+        collapsibleControlMock.verifyAll();
     });
 });

From 91aac64214dd6af1fb1e0748e93316d1a9e79f39 Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Mon, 8 Apr 2024 19:47:42 +0530
Subject: [PATCH 5/9] added verifiable

---
 .../report-sections/collapsible-url-result-section.test.tsx    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx b/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
index cb387c7d328..952ff3deb58 100644
--- a/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
+++ b/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
@@ -8,6 +8,7 @@ import {
     CollapsibleUrlResultSectionProps,
 } from 'reports/components/report-sections/collapsible-url-result-section';
 import { It, Mock } from 'typemoq';
+import { Times } from 'typemoq/Api/_all';
 
 describe('CollapsibleUrlResultSection', () => {
     it('renders', () => {
@@ -29,7 +30,7 @@ describe('CollapsibleUrlResultSection', () => {
 
         collapsibleControlMock
             .setup(cc => cc(It.isObjectWith(expectedCollapsibleControlProps)))
-            .returns(() => <div>Collapsible component</div>);
+            .returns(() => <div>Collapsible component</div>).verifiable(Times.once());
 
         const wrapper = render(<CollapsibleUrlResultSection {...props} />);
         expect(wrapper.asFragment()).toMatchSnapshot();

From fff0a64f6fe4a080492752d372b6443efcb344d8 Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Mon, 8 Apr 2024 19:52:36 +0530
Subject: [PATCH 6/9] Format fix

---
 .../report-sections/collapsible-url-result-section.test.tsx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx b/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
index 952ff3deb58..a74b5459ab2 100644
--- a/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
+++ b/src/tests/unit/tests/reports/components/report-sections/collapsible-url-result-section.test.tsx
@@ -7,8 +7,7 @@ import {
     CollapsibleUrlResultSection,
     CollapsibleUrlResultSectionProps,
 } from 'reports/components/report-sections/collapsible-url-result-section';
-import { It, Mock } from 'typemoq';
-import { Times } from 'typemoq/Api/_all';
+import { It, Mock, Times } from 'typemoq';
 
 describe('CollapsibleUrlResultSection', () => {
     it('renders', () => {
@@ -30,7 +29,8 @@ describe('CollapsibleUrlResultSection', () => {
 
         collapsibleControlMock
             .setup(cc => cc(It.isObjectWith(expectedCollapsibleControlProps)))
-            .returns(() => <div>Collapsible component</div>).verifiable(Times.once());
+            .returns(() => <div>Collapsible component</div>)
+            .verifiable(Times.once());
 
         const wrapper = render(<CollapsibleUrlResultSection {...props} />);
         expect(wrapper.asFragment()).toMatchSnapshot();

From 815b4d2956b9da84c5b5d73ffbaeb317a01988d6 Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Wed, 10 Apr 2024 12:59:45 +0530
Subject: [PATCH 7/9] removed includeStepsText

---
 .../components/default-test-view-container-provider.tsx          | 1 -
 .../default-test-view-container-provider.test.tsx.snap           | 1 -
 2 files changed, 2 deletions(-)

diff --git a/src/DetailsView/components/default-test-view-container-provider.tsx b/src/DetailsView/components/default-test-view-container-provider.tsx
index a8f9b3a8936..c1307fdba10 100644
--- a/src/DetailsView/components/default-test-view-container-provider.tsx
+++ b/src/DetailsView/components/default-test-view-container-provider.tsx
@@ -54,7 +54,6 @@ export class DefaultTestViewContainerProvider implements TestViewContainerProvid
                 instancesSection={FailedInstancesSection}
                 cardSelectionMessageCreator={props.assessmentCardSelectionMessageCreator}
                 cardsViewData={props.assessmentCardsViewData}
-                includeStepsText={false}
                 selectedVisualizationType={
                     props.assessmentStoreData?.assessmentNavState?.selectedTestType
                 }
diff --git a/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
index cbc22c48dc4..b385054b7a6 100644
--- a/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
@@ -8,7 +8,6 @@ exports[`DefaultTestViewContainerProvider can create assessment automated checks
   automatedChecksCardsViewData={{}}
   cardSelectionMessageCreator={{}}
   cardsViewData={{}}
-  includeStepsText={false}
   instancesSection={[Function]}
   needsReviewCardSelectionMessageCreator={{}}
   needsReviewCardsViewData={{}}

From 3d2d4a768fd21f7d483da8d04a053b0926c68f79 Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Wed, 10 Apr 2024 13:07:21 +0530
Subject: [PATCH 8/9] removed unsused includeStepsText property

---
 src/DetailsView/components/assessment-issues-test-view.tsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/DetailsView/components/assessment-issues-test-view.tsx b/src/DetailsView/components/assessment-issues-test-view.tsx
index fc80f4799bf..54a1f1b5472 100644
--- a/src/DetailsView/components/assessment-issues-test-view.tsx
+++ b/src/DetailsView/components/assessment-issues-test-view.tsx
@@ -35,7 +35,6 @@ export type AssessmentIssuesTestViewDeps = {
 export type AssessmentIssuesTestViewProps = {
     deps: AssessmentIssuesTestViewDeps;
     assessmentStoreData: AssessmentStoreData;
-    includeStepsText?: boolean;
 } & Omit<AdhocIssuesTestViewProps, 'deps'>;
 
 export class AssessmentIssuesTestView extends React.Component<AssessmentIssuesTestViewProps> {

From 0210d1b593fecf232c3ba03a324b38396158919a Mon Sep 17 00:00:00 2001
From: Jeevani Chinthala <v-jeevanic@microsoft.com>
Date: Thu, 11 Apr 2024 17:09:45 +0530
Subject: [PATCH 9/9] Added includeStepsText

---
 src/DetailsView/components/assessment-issues-test-view.tsx       | 1 +
 .../components/default-test-view-container-provider.tsx          | 1 +
 .../default-test-view-container-provider.test.tsx.snap           | 1 +
 3 files changed, 3 insertions(+)

diff --git a/src/DetailsView/components/assessment-issues-test-view.tsx b/src/DetailsView/components/assessment-issues-test-view.tsx
index 54a1f1b5472..fc80f4799bf 100644
--- a/src/DetailsView/components/assessment-issues-test-view.tsx
+++ b/src/DetailsView/components/assessment-issues-test-view.tsx
@@ -35,6 +35,7 @@ export type AssessmentIssuesTestViewDeps = {
 export type AssessmentIssuesTestViewProps = {
     deps: AssessmentIssuesTestViewDeps;
     assessmentStoreData: AssessmentStoreData;
+    includeStepsText?: boolean;
 } & Omit<AdhocIssuesTestViewProps, 'deps'>;
 
 export class AssessmentIssuesTestView extends React.Component<AssessmentIssuesTestViewProps> {
diff --git a/src/DetailsView/components/default-test-view-container-provider.tsx b/src/DetailsView/components/default-test-view-container-provider.tsx
index c1307fdba10..a8f9b3a8936 100644
--- a/src/DetailsView/components/default-test-view-container-provider.tsx
+++ b/src/DetailsView/components/default-test-view-container-provider.tsx
@@ -54,6 +54,7 @@ export class DefaultTestViewContainerProvider implements TestViewContainerProvid
                 instancesSection={FailedInstancesSection}
                 cardSelectionMessageCreator={props.assessmentCardSelectionMessageCreator}
                 cardsViewData={props.assessmentCardsViewData}
+                includeStepsText={false}
                 selectedVisualizationType={
                     props.assessmentStoreData?.assessmentNavState?.selectedTestType
                 }
diff --git a/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap b/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
index b385054b7a6..cbc22c48dc4 100644
--- a/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
+++ b/src/tests/unit/tests/DetailsView/components/__snapshots__/default-test-view-container-provider.test.tsx.snap
@@ -8,6 +8,7 @@ exports[`DefaultTestViewContainerProvider can create assessment automated checks
   automatedChecksCardsViewData={{}}
   cardSelectionMessageCreator={{}}
   cardsViewData={{}}
+  includeStepsText={false}
   instancesSection={[Function]}
   needsReviewCardSelectionMessageCreator={{}}
   needsReviewCardsViewData={{}}