Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility issues on 2.5.0 Insiders (validation bug) #805

Closed
Shobhit1 opened this issue Jun 14, 2019 · 5 comments
Closed

Accessibility issues on 2.5.0 Insiders (validation bug) #805

Shobhit1 opened this issue Jun 14, 2019 · 5 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.

Comments

@Shobhit1
Copy link
Contributor

Describe the bug

Found an a11y issue while validating Insiders 2.5.0 version.
Rule failed: label-content-name-mismatch

To Reproduce
Steps to reproduce the behavior:

  1. Go to Assessment View from the extension for any target page
  2. Open developer tools (F12) and type A11yselfvalidator.validate()
  3. See error

Expected behavior

A11ySelfvalidator should return [] on Assessment details view page.

Screenshots

image

Extension (please complete the following information)

Are you willing to submit a PR?

Yes.

Did you search for similar existing issues?

Yes
@Shobhit1 Shobhit1 added the bug Something isn't working label Jun 14, 2019
@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label Jun 14, 2019
@ferBonnin
Copy link
Contributor

3/4 issues are related to this dequelabs/axe-core#1635
the other one (link "see more info here") is a real issue.

@karanbirsingh karanbirsingh added the status: ready for work This issue is ready to be worked on. label Jun 17, 2019
@msft-github-bot msft-github-bot removed the status: new This issue is new and requires triage by DRI. label Jun 17, 2019
@Shobhit1
Copy link
Contributor Author

We partially fixed some of them and there is a bug on axe-core for a false positive for a rule in WCAG 2.1. So, I feel we can close this bug.
Reference bug: dequelabs/axe-core#1635

@ferBonnin
Copy link
Contributor

@Shobhit1 agree to close this issue.

@Shobhit1
Copy link
Contributor Author

Closing this one as fixed with https://github.com/microsoft/accessibility-insights-web/tree/v2.5.4

@ferBonnin
Copy link
Contributor

since this is closed marking it as resolved

@ferBonnin ferBonnin added the status: resolved This issue has been merged into main and deployed to canary. label Nov 14, 2019
@msft-github-bot msft-github-bot removed the status: ready for work This issue is ready to be worked on. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dbjorge @Shobhit1 @karanbirsingh @ferBonnin @msft-github-bot