Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usability] Make failure instance highlight more visible for Android #6341

Closed
katydecorah opened this issue Jan 11, 2023 · 2 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@katydecorah
Copy link
Contributor

Describe the bug

In #5610, and resolved in #6164, the injected highlight style was updated to improve its visibility. Android could also benefit from updating the style in Android's "Automated check" panel.

To Reproduce
Steps to reproduce the behavior:

  1. Open an app using Accessibility Insights for Android
  2. Visit Automated checks
  3. See the highlighted elements in the "Target app screenshot"

CodePen repro example

n/a

Expected behavior

The highlighted elements in Android use the new style introduced in #6164, which displays a red and white border.

Screenshots

The screenshot below shows the current highlight style which is a flat red border with an adjacent white-colored exclamation point inside a red square.

Context (please complete the following information)

  • OS Name & Version:
  • AI-Web Version & Environment: Accessibility Insights for Android 2023.109.3 Insider
  • Browser Version:
  • Target Page:

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Yes

Additional context

The current styles for the Android highlight box live in highlight-box.scss and are applied to highlight-box.tsx. Ideally, we would share the styles for the highlight box defined in injected.scss.

@katydecorah katydecorah added the bug Something isn't working label Jan 11, 2023
@ghost ghost added the status: new This issue is new and requires triage by DRI. label Jan 11, 2023
@ghost ghost assigned jlperkins Jan 11, 2023
@jlperkins jlperkins added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Jan 11, 2023
@ghost ghost assigned ferBonnin Jan 11, 2023
@ghost
Copy link

ghost commented Jan 11, 2023

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ferBonnin ferBonnin added status: ready for work This issue is ready to be worked on. good first issue Good for newcomers labels Feb 7, 2023
@DaveTryon DaveTryon removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Mar 30, 2023
@DaveTryon
Copy link
Contributor

We won't be fixing this

@DaveTryon DaveTryon removed the status: ready for work This issue is ready to be worked on. label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants