Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error occurs when running the Headings tool #4311

Closed
kidokidozh opened this issue May 31, 2021 · 4 comments
Closed

Error occurs when running the Headings tool #4311

kidokidozh opened this issue May 31, 2021 · 4 comments
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.

Comments

@kidokidozh
Copy link

Describe the bug

Cannot run the "Headings" tool. Our page is having some iframe inside it, not sure whether it's related. Errors output to browser console:

injected.bundle.js:77 failed to scan with error - TypeError: Cannot read property 'data' of undefined
injected.bundle.js:77 An axe-core error occurred while processing a result from a child frame.

Screenshots

image

Context (please complete the following information)

  • AI-Web Version & Environment: 2.26.1
  • Browser Version:
    Microsoft Edge Version 91.0.864.37 (Official build) (64-bit)
    Google Chrome Version 91.0.4472.77 (Official Build) (64-bit)
@kidokidozh kidokidozh added the bug Something isn't working label May 31, 2021
@ghost ghost added the status: new This issue is new and requires triage by DRI. label May 31, 2021
@ghost ghost assigned dbjorge May 31, 2021
@kidokidozh
Copy link
Author

I found it might be a bug of axe-core: dequelabs/axe-core#2965

@karanbirsingh
Copy link
Contributor

karanbirsingh commented Jun 1, 2021 •
edited
Loading

Thanks @kidokidozh for the report! I agree the issue you found seems like the root cause.

I can reproduce this issue when child iframe descendants have at least 2 headings in total. For instance, the following structures reproduce this issue (here's a live repro).

single iframe with two headings

index.html:

<html>
    outer page
    <iframe src="page-with-headings.html"></iframe>
</html>

page-with-headings.html:

<html>
    <h1>heading</h1>
    <h2>heading two</h2>
</html>
iframe with one heading that has a child iframe with another heading

index.html:

<html>
    outer page
    <iframe src="page-with-headings.html"></iframe>
</html>

page-with-headings.html:

<html>
    <h1>heading</h1>
    <iframe src="another-page-with-headings.html"></iframe>
</html>

another-page-with-headings.html:

<html>
    <h1>heading</h1>
</html>

Does your page match one of these structures?

user impact:

  • The headings ad-hoc visualization gets stuck. Users are unable to trigger other actions until refreshing or switching the target page.
  • No impact on automated checks in any of our products because we exclude heading-order (tagged as best-practice)
  • No impact on headings in assessment because we have a custom rule. We could explore switching from heading-order to collect-headings (custom rule in assessment) as a workaround.

We will look into this a little further. Thanks! In the meantime, you might try the Headings visualization in assessment instead.

@karanbirsingh karanbirsingh added the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jun 1, 2021
@ghost ghost assigned ferBonnin Jun 1, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Jun 1, 2021
@karanbirsingh karanbirsingh removed their assignment Jun 1, 2021
@karanbirsingh karanbirsingh mentioned this issue Jun 1, 2021
Merged
7 tasks
@karanbirsingh karanbirsingh added the status: active This issue is currently being worked on by someone. label Jun 1, 2021
@ghost ghost removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Jun 1, 2021
@karanbirsingh karanbirsingh added the status: resolved This issue has been merged into main and deployed to canary. label Jun 3, 2021
@ghost ghost removed the status: active This issue is currently being worked on by someone. label Jun 3, 2021
@karanbirsingh
Copy link
Contributor

Fixed in #4327 and released to canary https://chrome.google.com/webstore/detail/accessibility-insights-fo/hbcplehnakffdldhldncjlnbpfgogbem/related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status: resolved This issue has been merged into main and deployed to canary.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dbjorge @karanbirsingh @ferBonnin @kidokidozh