Postgen modal azure links don't redirect correctly

[jsondoo]

The links we have for the 3 services are:

1. Functions: https://portal.azure.com/#blade/WebsitesExtension/FunctionsIFrameBladeMain
2. Cosmos DB: https://portal.azure.com/#blade/HubsExtension/BrowseResourceBlade/resourceType/Microsoft.DocumentDb%2FdatabaseAccounts
3. App Service: https://ms.portal.azure.com/#blade/HubsExtension/BrowseResourceBlade/resourceType/Microsoft.Web%2Fsites

CosmosDB and App Service link takes you to the "All Resources" page rather than the "Cosmos DB" or "App Service" resource group pages when clicked on through the VSCode extension.

VSCode Issue: microsoft/vscode#45515
VSCode currently decodes the %2F into a slash, so it takes you to a different path.

[SahilTara]

By the way you might want to change ms.portal.azure.com/ to portal.azure.com

[SahilTara]

Hmm odd, not sure if i understand the issue.

is this not the right page? (Clicked on client side)

[jsondoo]

@SahilTara that is the right page, it seems to work when you click on the link on the running it on the browser, but for some reason it takes you somewhere else when you click the link through the vscode extension

[SahilTara]

Hmm that's really strange

[SahilTara]

Think you mean to add microsoft/vscode#45515 (if you scroll down in the link you posted they track decoding on the linked issue).

[jsondoo]

Think you mean to add microsoft/vscode#45515 (if you scroll down in the link you posted they track decoding on the linked issue).

Thanks, updated

[sibille]

VSCode tracking issue is microsoft/vscode#83645

[jrieken]

@sibille How do you open these links? Via vscode.env.openExternal or as links that the editor detects?

[sibille]

@jrieken I'd say a link that the editor detects: Link is shown in a react app running in the webview. Link rendering code in question is :

WebTemplateStudio/src/client/src/containers/PostGenerationModal/index.tsx

Line 86 in b51ca65

const LinkRenderer = (props: any) => (

[jrieken]

Can you try with latest insiders? That should have a fix for these issues

[sibille]

I tested with Insiders 1.41 and this seems still broken.
Source html is
<a href="https://portal.azure.com/#blade/HubsExtension/BrowseResourceBlade/resourceType/Microsoft.Web%2Fsites" class="styles_link__3M7Qr">View</a>

but then shows as

[jrieken]

The link that get's shown there must not be the link that gets opened, e.g the encoding in the dialog is likely different but I assume that opening is also not working, right? Is that html from an embedded webview?

[sibille]

I just double checked, the link is the same in the browser, so its not opening correct.

Is that html from an embedded webview?

Yes, Web Template Studio is shown in the embedded webview

[jrieken]

check - this should be better with next (Mondays) insiders build, microsoft/vscode#83645 (comment)

[sibille]

Working now on todays insider build.
Version: 1.41.0-insider (user setup)
Commit: 7cf4cca47aa025a590fc939af54932042302be63

The link is still showing up wrong in the popup, but leads to the correct place


Thanks @jrieken!

[sibille]

Verified on dev-nightly:
Templates version: 0.2.20120.1
Wizard version: 0.2.2012001