Enable Node.js/v8 compile caching via entrypoint shims #59720
Merged
+43
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
|
nodejs/node#54501 was merged into Node, so this API should end up available in a later version. I've marked this PR as ready for review, if we want to think about whether or not it's worth the extra shim / indirection. |
jakebailey
commented
Aug 30, 2024
| let output = options.output; | ||
| if (options.enableCompileCache) { | ||
| const originalOutput = output; | ||
| output = path.join(path.dirname(output), "_" + path.basename(output)); |
There was a problem hiding this comment.
This was just an expedient name choice; I can also remove the extension and then make it like tsc_.js which may sort better.
There was a problem hiding this comment.
I was going to say that _tsc tab-completes better on the command-line, though, because it doesn't interfere with types<TAB> -- but there's so much stuff in built/local that it doesn't actually make a difference.
|
@typescript-bot test startup-only [email protected],[email protected] |
|
@typescript-bot perf test startup-only [email protected],[email protected] |
|
Starting jobs; this comment will be updated as builds start and complete.
|
|
@jakebailey Here they are:
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jakebailey
requested review from
zkat,
DanielRosenwasser,
rbuckton,
RyanCavanaugh and
mjbvz
|
As a note to self, if/when we switch to ESM when const { createRequire, enableCompileCache } = process.getBuiltinModule("node:module");
enableCompileCache();
createRequire(import.meta.url)("./_tsc.js"); |
sandersn
approved these changes
Sep 25, 2024
| let output = options.output; | ||
| if (options.enableCompileCache) { | ||
| const originalOutput = output; | ||
| output = path.join(path.dirname(output), "_" + path.basename(output)); |
There was a problem hiding this comment.
I was going to say that _tsc tab-completes better on the command-line, though, because it doesn't interfere with types<TAB> -- but there's so much stuff in built/local that it doesn't actually make a difference.
|
@typescript-bot perf test this faster [email protected],[email protected] |
|
Starting jobs; this comment will be updated as builds start and complete.
|
|
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
mjbvz
added a commit
to mjbvz/vscode
that referenced
this pull request
Sep 27, 2024
mjbvz
added a commit
to microsoft/vscode
that referenced
this pull request
Sep 27, 2024
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of nodejs/node#54501 by converting our larger entrypoints (
tsc,tsserver,typingsInstaller) into shims which callrequire("node:module").enableCompileCache(), thenrequirethe actual code. Our entrypoints are assumed to always be run in Node (or a compatible runtime), so this is safe.This gives roughly a 2.5x startup time boost.
Gotchas:
_tsc.js,_tsserver.js,_typingsInstaller.js