No emit should happen if there are declaration errors and noEmitOnErrors is specified. #2431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors is specified.
| function getDeclarationDiagnosticsForFile(sourceFile: SourceFile): Diagnostic[] { | ||
| if (!isDeclarationFile(sourceFile)) { | ||
| let resolver = getDiagnosticsProducingTypeChecker().getEmitResolver(sourceFile); | ||
| return ts.getDeclarationDiagnostics(getEmitHost(), resolver, sourceFile); |
There was a problem hiding this comment.
Pass an empty writeFile callback so there are no side effects, i.e. emitting the files.
CyrusNajmabadi
added a commit
that referenced
this pull request
Mar 20, 2015
No emit should happen if there are declaration errors and noEmitOnErrors is specified.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.