Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ember] Intellisense dont work for this.[methodName] #8133

Closed
egamma opened this issue Apr 17, 2016 · 4 comments
Closed

[Ember] Intellisense dont work for this.[methodName] #8133

egamma opened this issue Apr 17, 2016 · 4 comments
Assignees

Comments

@egamma
Copy link
Member

egamma commented Apr 17, 2016

From @atcq1 on March 25, 2016 13:11

  • VSCode Version:0.10.11
  • OS Version:ubuntu 14.04 x64

Intellisense\autocomplete not work to call methods and property through this.methodName () / this.propertyName.

Steps to Reproduce:

  1. Create route:
import Ember from 'ember';

export default Ember.Route.extend({
    property1: 'text',
    model(params) {
        return {};
    },
    firstMethod()
    {
        //test1
    },
    secondMethod()
    {
        //test2        
    },
    thirdMethod()
    {
        //Intellisense
        secondMethod(); //work
        this.secondMethod(); //do not work
        //Autocomplete
        property1; //work
        this.property1; //do not work
    }
});

2 Enter this.second or this.prop in thirdMethod(){}:

Copied from original issue: microsoft/vscode#4671

@egamma egamma self-assigned this Apr 17, 2016
@egamma
Copy link
Member Author

egamma commented Apr 17, 2016

I don't think that Salsa supports this pattern, moving to TypeScript for comment.

@DanielRosenwasser
Copy link
Member

@sandersn you work now covers this correctly, right?

@DanielRosenwasser
Copy link
Member

Or is this a duplicate of #8110?

@sandersn
Copy link
Member

Yes, this works in Salsa (as well as TypeScript) if, in settings.json, you set "typescript.tsdk" to a directory that contains the bits from typescript@next.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants